From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756433AbYE2Oze@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756433AbYE2Oze (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 May 2008 10:55:34 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753584AbYE2OzY
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 29 May 2008 10:55:24 -0400
Received: from accolon.hansenpartnership.com ([76.243.235.52]:53195 "EHLO
	accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753344AbYE2OzX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 May 2008 10:55:23 -0400
Subject: Re: [PATCH] scsi: remove CDROM not ready printk
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Gerb Stralko <gerb.stralko@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       linux-scsi@vger.kernel.org
In-Reply-To: <75b57c110805290735i493eca0fp882f4a38901a416c@mail.gmail.com>
References: <alpine.LFD.1.10.0805271502370.3985@localhost.localdomain>
	 <20080529004154.bbc7b1d4.akpm@linux-foundation.org>
	 <1212069932.3428.1.camel@localhost.localdomain>
	 <75b57c110805290735i493eca0fp882f4a38901a416c@mail.gmail.com>
Content-Type: text/plain
Date: Thu, 29 May 2008 09:55:12 -0500
Message-Id: <1212072912.3428.28.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2008-05-29 at 10:35 -0400, Gerb Stralko wrote:
> So is that printk really needed?  Should the kernel even need to print
> a message like that, esp. if user-space is handling state updates and
> notifications.  Or do i need to configure hald to be quietier?   FWIW
> I'm using fedora core 9 and hald version:
> -bash-3.2$ /usr/sbin/hald --version
> HAL package version: 0.5.11

Actually, I misspoke; it's set internally via sets of ioctls.  However,
it's designed only to show on ioctls that do medium requiring things.

I'm also using FC9 and I see no such messages (and for noisy cgc,
they're printed out for every action on the CD).  You have some
application that's poking the CD wrongly (probably not hal), so you
really need to find out what it is.  It may be pointing to some other
error in the kernel that needs fixing, but simply removing the message
is covering up the issue.

To help track the application, you could update the printk to print out
current->comm and current->pid.  That would tell you who is responsible

James