mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
To: linux-mips@linux-mips.org, ralf@linux-mips.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] [MIPS] fix sparse warning about setup_early_printk()
Date: Thu, 29 May 2008 17:57:08 +0300	[thread overview]
Message-ID: <121207303298-git-send-email-dmitri.vorobiev@movial.fi> (raw)
In-Reply-To: <12120730323761-git-send-email-dmitri.vorobiev@movial.fi>

This patch fixes the following sparse warning:

<<<<<<<<

arch/mips/kernel/early_printk.c:35:13: warning: symbol 'setup_early_printk'
was not declared. Should it be static?

<<<<<<<<

The fix is to define a prototype of the setup_early_printk() function and
to include the appropriate header into arch/mips/kernel/early_printk.c.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
---
 arch/mips/kernel/early_printk.c |    1 +
 arch/mips/kernel/setup.c        |    6 +-----
 include/asm-mips/setup.h        |    2 ++
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/mips/kernel/early_printk.c b/arch/mips/kernel/early_printk.c
index 9dccfa4..cb602c1 100644
--- a/arch/mips/kernel/early_printk.c
+++ b/arch/mips/kernel/early_printk.c
@@ -7,6 +7,7 @@
  * Copyright (C) 2007 MIPS Technologies, Inc.
  *   written by Ralf Baechle (ralf@linux-mips.org)
  */
+#include <asm/setup.h>
 #include <linux/console.h>
 #include <linux/init.h>
 
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index c6a063b..0370794 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -557,11 +557,7 @@ void __init setup_arch(char **cmdline_p)
 	prom_init();
 
 #ifdef CONFIG_EARLY_PRINTK
-	{
-		extern void setup_early_printk(void);
-
-		setup_early_printk();
-	}
+	setup_early_printk();
 #endif
 	cpu_report();
 	check_bugs_early();
diff --git a/include/asm-mips/setup.h b/include/asm-mips/setup.h
index 70009a9..883f59b 100644
--- a/include/asm-mips/setup.h
+++ b/include/asm-mips/setup.h
@@ -3,4 +3,6 @@
 
 #define COMMAND_LINE_SIZE	256
 
+extern void setup_early_printk(void);
+
 #endif /* __SETUP_H */
-- 
1.4.4.3


  reply	other threads:[~2008-05-29 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29 14:57 [PATCH 0/5] [MIPS] sparse noise reduction and namespace cleanups Dmitri Vorobiev
2008-05-29 14:57 ` Dmitri Vorobiev [this message]
2008-05-29 14:57 ` [PATCH 2/5] [MIPS] Make two functions static Dmitri Vorobiev
2008-05-29 14:57 ` [PATCH 3/5] [MIPS] remove unused function alloc_legacy_irqno() Dmitri Vorobiev
2008-05-29 14:57 ` [PATCH 4/5] [MIPS] unexport {allocate,free}_irqno Dmitri Vorobiev
2008-05-29 14:57 ` [PATCH 5/5] [MIPS] The tickcount per-cpu variable can become static Dmitri Vorobiev
2008-05-30  7:58   ` Dmitri Vorobiev
2008-06-11 17:44   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=121207303298-git-send-email-dmitri.vorobiev@movial.fi \
    --to=dmitri.vorobiev@movial.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®