From: Zhao Yakui <yakui.zhao@intel.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Len Brown <len.brown@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [patch -v3 16/22] acpi: use memory_read_from_buffer
Date: Thu, 05 Jun 2008 09:21:26 +0800 [thread overview]
Message-ID: <1212628886.10730.2.camel@yakui_zhao.sh.intel.com> (raw)
In-Reply-To: <20080604115824.062644468@gmail.com>
On Wed, 2008-06-04 at 20:56 +0900, Akinobu Mita wrote:
> plain text document attachment
> (acpi-use-memory-read-from-buffer.patch)
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Len Brown <len.brown@intel.com>
> Cc: linux-acpi@vger.kernel.org
> ---
> drivers/acpi/system.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> Index: 2.6-git/drivers/acpi/system.c
> ===================================================================
> --- 2.6-git.orig/drivers/acpi/system.c
> +++ 2.6-git/drivers/acpi/system.c
> @@ -77,7 +77,6 @@ static ssize_t acpi_table_show(struct ko
> container_of(bin_attr, struct acpi_table_attr, attr);
> struct acpi_table_header *table_header = NULL;
> acpi_status status;
> - ssize_t ret_count = count;
>
> status =
> acpi_get_table(table_attr->name, table_attr->instance,
> @@ -85,18 +84,8 @@ static ssize_t acpi_table_show(struct ko
> if (ACPI_FAILURE(status))
> return -ENODEV;
>
> - if (offset >= table_header->length) {
> - ret_count = 0;
> - goto end;
> - }
> -
> - if (offset + ret_count > table_header->length)
> - ret_count = table_header->length - offset;
> -
> - memcpy(buf, ((char *)table_header) + offset, ret_count);
> -
> - end:
> - return ret_count;
> + return memory_read_from_buffer(buf, count, &offset,
> + table_header, table_header->length);
> }
it seems that there is no definition of memory_read_from_buffer.
Where is the function of memory_read_from_buffer defined?
Is there a bug about the current function of acpi_table_show?
Thanks.
>
> static void acpi_table_attr_init(struct acpi_table_attr *table_attr,
>
next prev parent reply other threads:[~2008-06-05 1:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 11:56 [patch -v3 00/22] use simple_read_from_buffer and memory_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 01/22] binfmt_misc: use simple_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 02/22] ocfs2: " Akinobu Mita
2008-06-06 22:46 ` Joel Becker
2008-06-04 11:56 ` [patch -v3 03/22] ipc: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 04/22] isdn: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 05/22] s390/vmcp: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 06/22] s390: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 07/22] nwflash: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 08/22] usbmon: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 09/22] ttusb: use simple_read_from_buffer() Akinobu Mita
2008-06-04 11:56 ` [patch -v3 10/22] airo: use simple_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 11/22] cris: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 12/22] introduce memory_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 13/22] dcdbas: use memory_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 14/22] dell_rbu: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 15/22] firmware: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 16/22] acpi: " Akinobu Mita
2008-06-05 1:21 ` Zhao Yakui [this message]
2008-06-05 1:29 ` Andrew Morton
2008-06-04 11:56 ` [patch -v3 17/22] aty: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 18/22] zorro: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 19/22] s390/cio: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 20/22] s390: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 21/22] ipr: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 22/22] qla2xxx: " Akinobu Mita
2008-06-06 17:06 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212628886.10730.2.camel@yakui_zhao.sh.intel.com \
--to=yakui.zhao@intel.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®