mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Thomas Tuttle <ttuttle@google.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] pagemap: Change kpagecount to return the map count, not the reference count, of a page.
Date: Thu, 05 Jun 2008 11:01:07 -0500	[thread overview]
Message-ID: <1212681667.3953.159.camel@calx> (raw)
In-Reply-To: <4ca0a85e0806050804s798bba46wcb29d2582120bfab@mail.gmail.com>


On Thu, 2008-06-05 at 11:04 -0400, Thomas Tuttle wrote:
> When trying to use pagemap to calculate the "proportional set size"
> [1] of a process, I discovered that there were often references to
> pages that could not be discovered by kpagecount.  I changed
> kpagecount to return the number of times a page is mapped, rather than
> referenced, so kpagecount is more useful for determining how many
> processes are using a page.

I'm pretty sure this has been suggested before and I was just too
thick-skulled to get it. Yes, the reference count is less useful.

Acked-by: Matt Mackall <mpm@selenic.com>

ps: It's much prefered to send patches inline.

-- 
Mathematics is the supreme nostalgia of our time.


  reply	other threads:[~2008-06-05 16:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05 15:04 Thomas Tuttle
2008-06-05 16:01 ` Matt Mackall [this message]
2008-06-05 16:03   ` Thomas Tuttle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212681667.3953.159.camel@calx \
    --to=mpm@selenic.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ttuttle@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®