From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Tuttle <ttuttle@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy_to_user instead of put_user.
Date: Thu, 05 Jun 2008 14:06:03 -0500 [thread overview]
Message-ID: <1212692763.3953.196.camel@calx> (raw)
In-Reply-To: <20080605120221.c09dc274.akpm@linux-foundation.org>
On Thu, 2008-06-05 at 12:02 -0700, Andrew Morton wrote:
> On Thu, 5 Jun 2008 11:04:21 -0400
> "Thomas Tuttle" <ttuttle@google.com> wrote:
>
> > While fiddling with pagemap, I discovered a bug in add_to_pagemap.
>
> so... afaict we have some fairly significant problems in here and a
> version 2 of the patchset is in order?
>
> If so, when preparing that patchset please do have a think about which
> of the fixes you believe should be backported into 2.6.25.x and prepare
> the patches so that those fixes come first, to ease that backporting.
For 2.6.25.x, we should probably just add a cast to the put_user dest.
Thomas?
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2008-06-05 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 15:04 Thomas Tuttle
2008-06-05 15:57 ` Matt Mackall
2008-06-05 16:01 ` Thomas Tuttle
2008-06-05 16:20 ` Matt Mackall
2008-06-05 19:02 ` Andrew Morton
2008-06-05 19:06 ` Matt Mackall [this message]
2008-06-05 19:09 ` Thomas Tuttle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212692763.3953.196.camel@calx \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ttuttle@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®