From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] jfs: remove DIRENTSIZ
Date: Tue, 10 Jun 2008 15:19:03 -0500 [thread overview]
Message-ID: <1213129143.6435.6.camel@norville.austin.ibm.com> (raw)
In-Reply-To: <20080609222729.GA1987@cs181133002.pp.htv.fi>
Ack.
Added to the jfs git tree. As this is an unused macro, removing the
definition of struct dirent shouldn't depend on this patch. Expect it
to make the 2.6.27 merge window.
Thanks,
Shaggy
On Tue, 2008-06-10 at 01:27 +0300, Adrian Bunk wrote:
> After fat gets fixed the unused DIRENTSIZ macro was the last user of
> struct dirent we should get rid of since the kernel and userspace
> versions differed.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> 89432c9b7ff2cd2e29fc5f2edde120dc38a89f46 diff --git a/fs/jfs/jfs_dtree.h b/fs/jfs/jfs_dtree.h
> index cdac2d5..2545bb3 100644
> --- a/fs/jfs/jfs_dtree.h
> +++ b/fs/jfs/jfs_dtree.h
> @@ -243,9 +243,6 @@ typedef union {
> #define JFS_REMOVE 3
> #define JFS_RENAME 4
>
> -#define DIRENTSIZ(namlen) \
> - ( (sizeof(struct dirent) - 2*(JFS_NAME_MAX+1) + 2*((namlen)+1) + 3) &~ 3 )
> -
> /*
> * Maximum file offset for directories.
> */
>
--
David Kleikamp
IBM Linux Technology Center
prev parent reply other threads:[~2008-06-10 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 22:27 Adrian Bunk
2008-06-10 20:19 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213129143.6435.6.camel@norville.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=bunk@kernel.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®