mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Alessandro Suardi <alessandro.suardi@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.26-rc5-git2] WARNING: at kernel/lockdep.c:2658 check_flags+0x4c/0x128()
Date: Thu, 12 Jun 2008 09:05:06 +0200	[thread overview]
Message-ID: <1213254306.31518.84.camel@twins> (raw)
In-Reply-To: <19f34abd0806112355v7330ccd4x41e66151f333c144@mail.gmail.com>

On Thu, 2008-06-12 at 08:55 +0200, Vegard Nossum wrote:


> From: Vegard Nossum <vegard.nossum@gmail.com>
> Date: Thu, 12 Jun 2008 08:49:18 +0200
> Subject: [PATCH] x86: more hardirq annotations for notify_die()
> 
> Reported-by: Alessandro Suardi <alessandro.suardi@gmail.com>
> Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
> ---
>  arch/x86/kernel/traps_32.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/traps_32.c b/arch/x86/kernel/traps_32.c
> index bde6f63..be9ecae 100644
> --- a/arch/x86/kernel/traps_32.c
> +++ b/arch/x86/kernel/traps_32.c
> @@ -569,6 +569,7 @@ void do_##name(struct pt_regs *regs, long error_code)			\
>  #define DO_VM86_ERROR(trapnr, signr, str, name)				\
>  void do_##name(struct pt_regs *regs, long error_code)			\
>  {									\
> +	trace_hardirqs_fixup();						\
>  	if (notify_die(DIE_TRAP, str, regs, error_code, trapnr, signr)	\
>  						== NOTIFY_STOP)		\
>  		return;							\

Yeah, I think this is ok, actual traps don't have any way of knowing the
actual IRQ state afaik. So

Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>


  reply	other threads:[~2008-06-12  7:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11 22:06 Alessandro Suardi
2008-06-12  6:55 ` Vegard Nossum
2008-06-12  7:05   ` Peter Zijlstra [this message]
2008-06-12  7:30     ` Ingo Molnar
2008-06-12 10:56       ` Alessandro Suardi
2008-06-21 17:22         ` Alessandro Suardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213254306.31518.84.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=alessandro.suardi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®