From: "Huang, Ying" <ying.huang@intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX] lockdep: output lock_class key instead of address for forward dependency output
Date: Fri, 13 Jun 2008 15:26:05 +0800 [thread overview]
Message-ID: <1213341965.17201.15.camel@caritas-dev.intel.com> (raw)
In-Reply-To: <20080613065809.GA28810@elte.hu>
On Fri, 2008-06-13 at 08:58 +0200, Ingo Molnar wrote:
> * Huang, Ying <ying.huang@intel.com> wrote:
>
> > The key instead of address of lock_class should be output in
> > /proc/lockdep when forward dependency is output, because key is
> > output for lock_class itself as identifier too.
> >
> > This patch is based on x86/auto-latest branch of git-x86 tree, and has
> > been tested on x86_64 platform.
>
> applied to tip/core/locking - thanks Ying.
>
> i'm wondering, can entry->class never be NULL here?
As far as I know, it can never be NULL. Because entry is added into
class->locks_after in following call chain:
lock_acquire -> __lock_acquire -> validate_chain -> check_prevs_add ->
check_prev_add -> add_lock_to_list
in __lock_acquire the lock_class is look up or registered from
lockdep_map and put in held_lock, which is used in following function in
call chain.
Best Regards,
Huang Ying
prev parent reply other threads:[~2008-06-13 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 6:40 Huang, Ying
2008-06-13 6:58 ` Ingo Molnar
2008-06-13 7:26 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213341965.17201.15.camel@caritas-dev.intel.com \
--to=ying.huang@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®