mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukas Lipavsky <llipavsky@suse.cz>
To: Jan Beulich <jbeulich@novell.com>
Cc: sam@ravnborg.org, stable@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move __attribute__((__cold__)) functions back into final .text section
Date: Fri, 20 Jun 2008 11:06:17 +0200	[thread overview]
Message-ID: <1213952777.9696.3.camel@hex.suse.cz> (raw)
In-Reply-To: <48590F41.76E4.0078.0@novell.com>

Jan Beulich píše v St 18. 06. 2008 v 12:36 +0100:
> Due to the addition of __attribute__((__cold__)) to a few symbols
> without adjusting the linker scripts, those symbols currently may end
> up outside the [_stext,_etext) range, as they get placed in
> .text.unlikely by (at least) gcc 4.3.0. This may confuse code not only
> outside of the kernel, symbol_put_addr()'s BUG() could also trigger.
> Hence we need to add .text.unlikely (and for future uses of
> __attribute__((__hot__)) also .text.hot) to the TEXT_TEXT() macro.
> Cc: Lukas Lipavsky <llipavsky@suse.cz>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>

Tested-by: Lukas Lipavsky <llipavsky@suse.cz>



  reply	other threads:[~2008-06-20  9:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 11:36 Jan Beulich
2008-06-20  9:06 ` Lukas Lipavsky [this message]
2008-06-27 21:03 ` Sam Ravnborg
2008-07-02  6:17 ` Andrew Morton
2008-07-02  6:29   ` Stephen Rothwell
2008-07-06 21:12   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213952777.9696.3.camel@hex.suse.cz \
    --to=llipavsky@suse.cz \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome