On Thu, 2008-06-19 at 23:52 -0700, Joel Becker wrote: > On Fri, Jun 20, 2008 at 04:19:10PM +1000, Ben Nizette wrote: > > Looks great, thx :-). I'll convert some of my stuff over to this > > interface and see how it flies in the real world. > > Excellent. What is your stuff, btw? Got code? Love to see it. I've done a few things recently. Haavard Skinnemoen has got an out-of-tree, avr32-specific gpio interface [1] which I first converted to the generic gpio framework then completely re-wrote. Both use configfs but before either version could reach completion they were obsoleted by David Brownell's gpio sysfs interface. A version of my gpio-dev interface is attached. Bear in mind it was never completed, it's full of known bugs but hey, might be useful for you anyway :-) At the moment I'm experimenting with configfs for pinmux control on AVR32 SoCs. There's really nothing to see there yet, it's all just dicking about atm. > > > ISTR when I did this I kept the old semantics and used ERR_PTR and > > friends if things went pear-shaped. Given the small number of in-tree > > users needing to be moved over, a more intrusive change for the sake of > > a cleaner API like you've done is probably a good thing anyway :-) > > Yeah, I like this better than ERR_PTR. > If you like the macros, I'll try to make the next merge window > as well. So let me know. np, will do :-) --Ben. > > joel > [1] http://git.kernel.org/?p=linux/kernel/git/hskinnemoen/avr32-2.6.git;a=blob;f=arch/avr32/mach-at32ap/gpio-dev.c;h=8cf6d1182c31db88fc069a046112a4eaac589308;hb=atmel-2.6.25