mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, vgoyal@redhat.com,
	kexec@lists.infradead.org, yhlu.kernel@gmail.com,
	Bernhard Walle <bwalle@suse.de>
Subject: [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX
Date: Wed, 25 Jun 2008 14:02:21 +0200	[thread overview]
Message-ID: <1214395342-20375-3-git-send-email-bwalle@suse.de> (raw)
In-Reply-To: <1214395342-20375-1-git-send-email-bwalle@suse.de>

Allow the specifying of ULLONG_MAX to limit the whole E820 map from the
specified start to the end. Without the patch, there would be integer
overflows.


Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 arch/x86/kernel/e820.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index e466073..7d1109b 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -397,6 +397,9 @@ int __init copy_e820_map(struct e820entry *biosmap, int nr_map)
 	return __copy_e820_map(biosmap, nr_map);
 }
 
+/*
+ * Pass size == ULLONG_MAX to update until the end.
+ */
 u64 __init e820_update_range(u64 start, u64 size, unsigned old_type,
 				unsigned new_type)
 {
@@ -412,14 +415,18 @@ u64 __init e820_update_range(u64 start, u64 size, unsigned old_type,
 			continue;
 		/* totally covered? */
 		if (ei->addr >= start &&
-		    (ei->addr + ei->size) <= (start + size)) {
+		    (((ei->addr + ei->size) <= (start + size)) ||
+			    (size == ULLONG_MAX))) {
 			ei->type = new_type;
 			real_updated_size += ei->size;
 			continue;
 		}
 		/* partially covered */
 		final_start = max(start, ei->addr);
-		final_end = min(start + size, ei->addr + ei->size);
+		if (size == ULLONG_MAX)
+			final_end = ei->addr + ei->size;
+		else
+			final_end = min(start + size, ei->addr + ei->size);
 		if (final_start >= final_end)
 			continue;
 		ei->size -= final_end - final_start;
-- 
1.5.4.5


  parent reply	other threads:[~2008-06-25 12:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 12:02 Limit E820 map when specifying mem parameter Bernhard Walle
2008-06-25 12:02 ` [PATCH 1/3] e820_update_range(): Strip size of original region Bernhard Walle
2008-06-25 15:56   ` Yinghai Lu
2008-06-25 12:02 ` Bernhard Walle [this message]
2008-06-25 12:02 ` [PATCH 3/3] Limit E820 map when a user-defined memory map is specified Bernhard Walle
2008-06-25 16:01   ` Yinghai Lu
2008-06-25 16:03     ` Bernhard Walle
2008-06-25 16:58       ` Yinghai Lu
2008-06-25 19:39         ` Bernhard Walle
  -- strict thread matches above, loose matches on Subject: below --
2008-06-24 14:35 Limit E820 map when specifying mem parameter Bernhard Walle
2008-06-24 14:35 ` [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX Bernhard Walle
2008-06-24 20:01   ` Yinghai Lu
2008-06-24 20:21     ` Yinghai Lu
2008-06-25 12:05       ` Bernhard Walle
2008-06-25 15:44         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214395342-20375-3-git-send-email-bwalle@suse.de \
    --to=bwalle@suse.de \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®