mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ian <spyro@f2s.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Alberto Mardegan <mardy@users.sourceforge.net>,
	Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] w100fb: add 80 MHz modeline
Date: Sun, 29 Jun 2008 16:49:27 +0100	[thread overview]
Message-ID: <1214754567.8407.52.camel@wirenth> (raw)
In-Reply-To: <1214747627.2758.1.camel@localhost.localdomain>

On Sun, 2008-06-29 at 15:53 +0200, Philipp Zabel wrote:

Looks fine to me.   'lock time' looks a bit low but since the PLL is
very poorly understood (I wrote the c based on winCE disassembly) if it
works, go for it.

> This is needed for HTC Blueangel (w3200).
> At 96MHz its screen flickers.
> 
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>

  Acked-by: Ian Molton <spyro@f2s.com>

> ---
>  drivers/video/w100fb.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/w100fb.c b/drivers/video/w100fb.c
> index 30469bf..3e48eef 100644
> --- a/drivers/video/w100fb.c
> +++ b/drivers/video/w100fb.c
> @@ -1003,6 +1003,7 @@ static struct w100_pll_info xtal_14318000[] = {
>  static struct w100_pll_info xtal_16000000[] = {
>  	/*freq     M   N_int    N_fac  tfgoal  lock_time */
>  	{ 72,      1,   8,       0,     0xe0,        48}, /* tfgoal guessed */
> +	{ 80,      1,   9,       0,     0xe0,        13}, /* tfgoal guessed */
>  	{ 95,      1,   10,      7,     0xe0,        38}, /* tfgoal guessed */
>  	{ 96,      1,   11,      0,     0xe0,        36}, /* tfgoal guessed */
>  	{  0,      0,   0,       0,        0,         0},


      reply	other threads:[~2008-06-29 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-29 13:53 Philipp Zabel
2008-06-29 15:49 ` ian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214754567.8407.52.camel@wirenth \
    --to=spyro@f2s.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mardy@users.sourceforge.net \
    --cc=philipp.zabel@gmail.com \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®