mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: kbuild <linux-kbuild@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, Roman Zippel <zippel@linux-m68k.org>
Subject: [PATCH 24/24] kconfig: make defconfig is no longer chatty
Date: Mon, 30 Jun 2008 23:35:18 +0200	[thread overview]
Message-ID: <1214861718-32626-24-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20080630213155.GA32479@uranus.ravnborg.org>

make defconfig generated a lot of output
then noone actually read.
Use conf_set_all_new_symbols() to generate the default
configuration and avoid the chatty output.

A typical run now looks like this:
$ make  defconfig
*** Default configuration is based on 'i386_defconfig'
arch/x86/configs/i386_defconfig:13:warning: trying to assign nonexistent symbol SEMAPHORE_SLEEPERS
arch/x86/configs/i386_defconfig:176:warning: trying to assign nonexistent symbol PREEMPT_BKL
...
arch/x86/configs/i386_defconfig:1386:warning: trying to assign nonexistent symbol INSTRUMENTATION
$

As an added benefit we now clearly see the warnings generated
in the start of the process.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
---
 scripts/kconfig/conf.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 6cdaa0c..9fba838 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -102,9 +102,6 @@ static int conf_askvalue(struct symbol *sym, const char *def)
 		fflush(stdout);
 		fgets(line, 128, stdin);
 		return 1;
-	case set_default:
-		printf("%s\n", def);
-		return 1;
 	default:
 		break;
 	}
@@ -318,10 +315,6 @@ static int conf_choice(struct menu *menu)
 			else
 				continue;
 			break;
-		case set_default:
-			cnt = def;
-			printf("%d\n", cnt);
-			break;
 		default:
 			break;
 		}
@@ -589,13 +582,15 @@ int main(int ac, char **av)
 	case set_random:
 		conf_set_all_new_symbols(def_random);
 		break;
+	case set_default:
+		conf_set_all_new_symbols(def_default);
+		break;
 	case ask_silent:
 	case ask_new:
 		if (conf_silent_update())
 			exit(1);
 		break;
 	case ask_all:
-	case set_default:
 		if (conf_update())
 			exit(1);
 		break;
-- 
1.5.6.1.93.gef98


      parent reply	other threads:[~2008-06-30 21:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 21:31 kbuild - pending stuff, and Maintainer news Sam Ravnborg
2008-06-30 21:34 ` [PATCH 01/24] kbuild: refactor headers_* targets in Makefile Sam Ravnborg
2008-06-30 21:34 ` [PATCH 02/24] kbuild: always unifdef files in headers_install* Sam Ravnborg
2008-06-30 21:34 ` [PATCH 03/24] kbuild: drop support of ALTARCH for headers_* Sam Ravnborg
2008-06-30 21:34 ` [PATCH 04/24] kbuild: code refactoring in Makefile.headerinst Sam Ravnborg
2008-06-30 21:34 ` [PATCH 05/24] kbuild: error out early in make headers_install Sam Ravnborg
2008-06-30 21:35 ` [PATCH 06/24] kbuild: only one call for include/ in make headers_* Sam Ravnborg
2008-06-30 21:35 ` [PATCH 07/24] kbuild: optimize headers_* targets Sam Ravnborg
2008-06-30 21:35 ` [PATCH 08/24] kbuild: make clean removes *.o.* as well Sam Ravnborg
2008-07-01 12:10   ` Jan Engelhardt
2008-07-01 20:21     ` Sam Ravnborg
2008-06-30 21:35 ` [PATCH 09/24] kbuild: install all headers when arch is changed Sam Ravnborg
2008-06-30 21:35 ` [PATCH 10/24] kbuild: prepare headers_* for arch/$ARCH/include Sam Ravnborg
2008-06-30 21:35 ` [PATCH 11/24] kbuild: support arch/$ARCH/include for tags, cscope Sam Ravnborg
2008-06-30 21:35 ` [PATCH 12/24] kbuild: asm symlink support for arch/$ARCH/include Sam Ravnborg
2008-06-30 21:35 ` [PATCH 13/24] kbuild: add arch/$ARCH/include to search path Sam Ravnborg
2008-06-30 21:35 ` [PATCH 15/24] vmlinux.lds: move __attribute__((__cold__)) functions back into final .text section Sam Ravnborg
2008-06-30 21:35 ` [PATCH 16/24] kernel-doc: handle/strip __init Sam Ravnborg
2008-06-30 21:35 ` [PATCH 17/24] kbuild: sparse needs CF not CHECKFLAGS Sam Ravnborg
2008-06-30 21:35 ` [PATCH 18/24] kbuild: remove Module.markers during mrproper Sam Ravnborg
2008-06-30 21:35 ` [PATCH 19/24] kconfig: add diffconfig utility Sam Ravnborg
2008-06-30 21:35 ` [PATCH 20/24] kconfig: set all new symbols automatically Sam Ravnborg
2008-06-30 21:35 ` [PATCH 21/24] kconfig: prefix hex values with 0x in .config Sam Ravnborg
2008-07-01  6:41   ` Ingo Molnar
2008-07-01  8:08     ` Sam Ravnborg
2008-06-30 21:35 ` [PATCH 22/24] kconfig: speed up all*config + randconfig Sam Ravnborg
2008-06-30 21:35 ` [PATCH 23/24] kconfig: make oldconfig is now less chatty Sam Ravnborg
2008-06-30 21:35 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214861718-32626-24-git-send-email-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®