mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: drzeus-list@drzeus.cx, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] MMC: fix sdio_io sparse errors
Date: Tue, 01 Jul 2008 03:54:55 +0200	[thread overview]
Message-ID: <1214877295.11537.97.camel@violet.holtmann.net> (raw)
In-Reply-To: <1214869984-20115-3-git-send-email-tomas.winkler@intel.com>

Hi Tomas,

>  	if (blksz == 0) {
> -		blksz = min(min(
> -			func->max_blksize,
> -			func->card->host->max_blk_size),
> -			512u);
> +		blksz = min(func->max_blksize, func->card->host->max_blk_size);
> +		blksz = min(blksz, 512u);
>  	}

I agree that your version is more readable, but I would be still
interested in which sparse error this fixes.

Other than that the patch looks good.

Regards

Marcel



  parent reply	other threads:[~2008-07-01  1:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 23:53 [PATCH 1/5 V2] MMC: core - fix the use of hard coded timeout value Tomas Winkler
2008-06-30 23:53 ` [PATCH 2/5 V2] MMC: wbsd.c fix shadowing of 'dma' variable Tomas Winkler
2008-06-30 23:53   ` [PATCH 3/5] MMC: fix sdio_io sparse errors Tomas Winkler
2008-06-30 23:53     ` [PATCH 4/5] MMC: fix spares errors of sdhci.c Tomas Winkler
2008-06-30 23:53       ` [PATCH 5/5] MMC: cleanup endianity conversions Tomas Winkler
2008-07-01  1:51         ` Marcel Holtmann
2008-07-01  1:47       ` [PATCH 4/5] MMC: fix spares errors of sdhci.c Marcel Holtmann
2008-07-01  1:54     ` Marcel Holtmann [this message]
2008-07-01  1:44   ` [PATCH 2/5 V2] MMC: wbsd.c fix shadowing of 'dma' variable Marcel Holtmann
2008-07-05 22:38   ` Pierre Ossman
2008-07-01  1:45 ` [PATCH 1/5 V2] MMC: core - fix the use of hard coded timeout value Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214877295.11537.97.camel@violet.holtmann.net \
    --to=marcel@holtmann.org \
    --cc=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome