From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755196AbYGBNtx (ORCPT ); Wed, 2 Jul 2008 09:49:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752568AbYGBNto (ORCPT ); Wed, 2 Jul 2008 09:49:44 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:44956 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbYGBNto (ORCPT ); Wed, 2 Jul 2008 09:49:44 -0400 X-Sasl-enc: o5oxM0NTZGdKWeOeikU8k3Ha19galOk6WaCa2FPy962e 1215006582 Subject: Re: [PATCH] autofs4 - detect invalid direct mount requests From: Ian Kent To: Jeff Moyer Cc: Andrew Morton , Kernel Mailing List , autofs mailing list , linux-fsdevel In-Reply-To: References: <20080620051301.9988.94307.stgit@raven.themaw.net> Content-Type: text/plain Date: Wed, 02 Jul 2008 21:46:41 +0800 Message-Id: <1215006402.3046.72.camel@raven.themaw.net> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-5.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2008-06-20 at 09:00 -0400, Jeff Moyer wrote: > Ian Kent writes: > > > autofs v5 dierct and offset mounts within an autofs filesystem are > > triggered by existing autofs triger mounts so the mount point dentry > > must be positive. If the mount point dentry is negative then the > > trigger doesn't exist so we can return fail immediately. > > What are the conditions that lead us here in that case? A multi-mount that has no root mount gets a lookup for an offset that doesn't exist (ie. the trigger hasn't been mounted). Then ->lookup() will create a negative dentry and send a mount request to the daemon. It is a bit of a special case but it helps a little. Ian