From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758809AbYGFQyS (ORCPT ); Sun, 6 Jul 2008 12:54:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757611AbYGFQyE (ORCPT ); Sun, 6 Jul 2008 12:54:04 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:53725 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757218AbYGFQyD (ORCPT ); Sun, 6 Jul 2008 12:54:03 -0400 Subject: Re: [PATCH] dsp56k: use request_firmware From: David Woodhouse To: Jaswinder Singh Cc: Fredrik Noring , LKML , kernelnewbies , kernel-janitors , Alan Cox , lars@nocrew.org, tomas@nocrew.org In-Reply-To: <1215358732.2817.11.camel@jaswinder.satnam> References: <1215253496.7816.7.camel@jaswinder.satnam> <1215357224.2817.2.camel@jaswinder.satnam> <43A34816-3B93-4D05-AE0A-65C0FBF35589@nocrew.org> <1215358732.2817.11.camel@jaswinder.satnam> Content-Type: text/plain Date: Sun, 06 Jul 2008 17:54:07 +0100 Message-Id: <1215363247.3189.113.camel@shinybook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2008-07-06 at 21:08 +0530, Jaswinder Singh wrote: > Hello Fredrik, > > On Sun, 2008-07-06 at 17:36 +0200, Fredrik Noring wrote: > > Hi Jaswinder, > > > > 6 jul 2008 kl. 17.13 skrev Jaswinder Singh: > > > Updated patch : > > > http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git?a=commitdiff;h=4f5b8828113ea857a7b590b7dbb8a5ee78103de4 +Licence: GPL +Assembly Source Code of ~50 lines can be generated by disassemble Shouldn't that be 'GPLv2'? And it's better just to say '...but original assembler source code lost' than to point say that it can be disassembled. It would be better still to dig out a DSP56001 disassembler and actually disassemble it. Why don't you do that? > > > Thanks for you comments. > > > > Excellent. (Unfortunately I don't have access to the hardware to test > > these changes.) > > Please test this and let us know the result. He said he can't. > Please upload assembly code with Licence on Net so that I can point > Assembly Source code in firmware/WHENCE. I don't think he has it. That's why he suggested a disassembler. -- dwmw2