From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484AbcBJRRb (ORCPT ); Wed, 10 Feb 2016 12:17:31 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:49699 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbcBJRR3 (ORCPT ); Wed, 10 Feb 2016 12:17:29 -0500 Date: Wed, 10 Feb 2016 12:17:26 -0500 (EST) From: Julien Grossholtz To: linus walleij Cc: gnurou@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter , kernel@savoirfairelinux.com Message-ID: <1215789090.353270.1455124646607.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <1455123514-17152-1-git-send-email-julien.grossholtz@savoirfairelinux.com> References: <1455123514-17152-1-git-send-email-julien.grossholtz@savoirfairelinux.com> Subject: Re: [PATCH] gpio: TS-4800: remove useless bgpio_init flags MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.6.0_GA_1153 (ZimbraWebClient - FF41 (Linux)/8.6.0_GA_1153) Thread-Topic: gpio: TS-4800: remove useless bgpio_init flags Thread-Index: f83jsVyNOiDLlPJxqnevTiRpPR6OFg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Julien Grossholtz" To: "linus walleij" Cc: gnurou@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, "Dan Carpenter" , kernel@savoirfairelinux.com, "Julien Grossholtz" Sent: Wednesday, February 10, 2016 11:58:34 AM Subject: [PATCH] gpio: TS-4800: remove useless bgpio_init flags No flags are required for bgpio_init in the TS-4800 gpio driver. This patch set zero instead. The driver will have the same behaviour since the | operator between the flags already resulted to zero. There is a typo here, I will send it again. Fixes: 5041e791440a ("gpio: add TS-4800 fpga GPIO support") Signed-off-by: Julien Grossholtz --- drivers/gpio/gpio-ts4800.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c index c4908a4..9da79e4 100644 --- a/drivers/gpio/gpio-ts4800.c +++ b/drivers/gpio/gpio-ts4800.c @@ -48,8 +48,7 @@ static int ts4800_gpio_probe(struct platform_device *pdev) retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET, base_addr + OUTPUT_REG_OFFSET, NULL, - base_addr + DIRECTION_REG_OFFSET, NULL, - BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER); + base_addr + DIRECTION_REG_OFFSET, NULL, 0); if (retval) { dev_err(&pdev->dev, "bgpio_init failed\n"); return retval; -- 2.5.0