Re: [PATCH] x86: Introducing asm-x86/syscalls.h

[Jaswinder Singh <jaswinder@infradead.org>]

Hello David,

On Tue, 2008-07-15 at 07:58 -0700, David Woodhouse wrote:

> I don't like this bit though:
> 
> > --- a/include/linux/syscalls.h
> > +++ b/include/linux/syscalls.h
> > @@ -65,6 +65,10 @@ struct getcpu_cache;
> >  #include <linux/quota.h>
> >  #include <linux/key.h>
> >  
> > +#ifdef CONFIG_X86
> > +#include <asm/syscalls.h>
> > +#endif
> > +
> >  asmlinkage long sys_time(time_t __user *tloc);
> >  asmlinkage long sys_stime(time_t __user *tptr);
> >  asmlinkage long sys_gettimeofday(struct timeval __user *tv,
> 
> We're going to want to do this for all architectures, aren't we? Perhaps
> it's better to provide <asm/syscalls.h> for all architectures from the
> beginning, and not bother with the ifdef? Or if you must have an ifdef,
> perhaps make it on something like ARCH_HAS_ASM_SYSCALLS_H rather than
> having to change it every time an architecture adds its own
> <asm/syscalls.h> file?
> 

OK, I will also create asm/syscalls.h for all the architectures.

Thank you,

Jaswinder Singh.