mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Adam Greenblatt <adam.greenblatt@gmail.com>
Cc: akpm@linux-foundation.org, jack@ucw.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.26] isofs: fix minor filesystem corruption, take 2
Date: Wed, 16 Jul 2008 11:23:23 +0300	[thread overview]
Message-ID: <1216196604.6762.57.camel@penberg-laptop> (raw)
In-Reply-To: <487DAEDB.3020007@gmail.com>

Hi Adam,

On Tue, 2008-07-15 at 22:18 -1000, Adam Greenblatt wrote:
> Some iso9660 images contain files with rockridge data that is either 
> incorrect or
> incompletely parsed.  Prior to commit 
> f2966632a134e865db3c819346a1dc7d96e05309,
> (included with kernel 2.6.13) the kernel ignored the rockridge data for 
> these files,
> while still allowing the files to be accessed under their non-rockridge 
> names.  That
> commit inadvertently changed things so that files with invalid rockridge 
> data could
> not be accessed  at all.  (I ran across the problem when comparing some 
> old CDs with
> hard disk copies I had made long ago under kernel 2.4: a few of the 
> files on the hard
> disk copies were no longer visible on the CDs.)
> 
> This change reverts to the pre-2.6.13 behavior.
> 
> Signed-off-by: Adam Greenblatt <adam.greenblatt@gmail.com>
> ---
> Pekka Enberg correctly pointed out that there was a similar change made to
> parse_rock_ridge_inode_internal() that should also be reverted.  Please 
> ignore
> my previous patch, and use this patch instead.  Thanks Pekka!

Looks good to me.

Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>


      reply	other threads:[~2008-07-16  8:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16  8:18 Adam Greenblatt
2008-07-16  8:23 ` Pekka Enberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216196604.6762.57.camel@penberg-laptop \
    --to=penberg@cs.helsinki.fi \
    --cc=adam.greenblatt@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®