mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>, Al Viro <viro@ZenIV.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vfs: use kstrdup() and check failing allocation
Date: Mon, 21 Jul 2008 13:18:15 +0300	[thread overview]
Message-ID: <1216635495.19173.48.camel@penberg-laptop> (raw)
In-Reply-To: <20080721101623.GB7694@lenovo>

On Mon, 2008-07-21 at 14:16 +0400, Cyrill Gorcunov wrote:
> [Li Zefan - Mon, Jul 21, 2008 at 06:06:36PM +0800]
> | - use kstrdup() instead of kmalloc() + memcpy()
> | - return NULL if allocating ->mnt_devname failed
> | - mnt_devname should be const
> | 
> | Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> | ---
> | 
> |   Andrew, please drop vfs-use-kstrdup.patch
> | 
> | ---
> 
> Thanks Li. I think Al will be fine with this version.
> 
> So if you needed:
> Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>

Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>


  reply	other threads:[~2008-07-21 10:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21 10:06 Li Zefan
2008-07-21 10:16 ` Cyrill Gorcunov
2008-07-21 10:18   ` Pekka Enberg [this message]
2008-07-21 13:24   ` Al Viro
2008-07-21 14:56     ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216635495.19173.48.camel@penberg-laptop \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®