mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [git pull] scheduler updates for v2.6.27, phase #2
Date: Mon, 21 Jul 2008 13:16:33 -0700	[thread overview]
Message-ID: <1216671393.2294.49.camel@dhcp32.mvista.com> (raw)
In-Reply-To: <1216668182.7257.80.camel@twins>

On Mon, 2008-07-21 at 21:23 +0200, Peter Zijlstra wrote:

> Does this work for you?
> 

Yours removed the warning .. I made an alternate one below only compile
tested, your choice..

Signed-off-by: Daniel Walker <dwalker@mvista.com>


diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index 47ceac9..febb864 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -242,7 +242,7 @@ static int do_balance_runtime(struct rt_rq *rt_rq)
 	rt_period = ktime_to_ns(rt_b->rt_period);
 	for_each_cpu_mask(i, rd->span) {
 		struct rt_rq *iter = sched_rt_period_rt_rq(rt_b, i);
-		s64 diff;
+		u64 diff;
 
 		if (iter == rt_rq)
 			continue;
@@ -252,7 +252,7 @@ static int do_balance_runtime(struct rt_rq *rt_rq)
 			goto next;
 
 		diff = iter->rt_runtime - iter->rt_time;
-		if (diff > 0) {
+		if ((s64)(diff) > 0) {
 			do_div(diff, weight);
 			if (rt_rq->rt_runtime + diff > rt_period)
 				diff = rt_period - rt_rq->rt_runtime;



  reply	other threads:[~2008-07-21 20:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21 15:38 Ingo Molnar
2008-07-21 16:31 ` Daniel Walker
2008-07-21 19:23   ` Peter Zijlstra
2008-07-21 20:16     ` Daniel Walker [this message]
2008-07-24 10:43       ` Peter Zijlstra
2008-07-24 11:09         ` Andrew Morton
2008-07-24 11:15           ` Peter Zijlstra
2008-07-24 11:24         ` Ingo Molnar
2008-07-24 19:12           ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216671393.2294.49.camel@dhcp32.mvista.com \
    --to=dwalker@mvista.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®