From: Jaswinder Singh <jaswinder@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] x86: declaration fixes
Date: Tue, 22 Jul 2008 11:27:01 +0530 [thread overview]
Message-ID: <1216706221.2595.8.camel@jaswinder.satnam> (raw)
In-Reply-To: <20080721180439.GA13720@elte.hu>
Hello Ingo,
On Mon, 2008-07-21 at 20:04 +0200, Ingo Molnar wrote:
> * Jaswinder Singh <jaswinder@infradead.org> wrote:
>
> another thing:
>
> --- a/include/asm-x86/signal.h
> +++ b/include/asm-x86/signal.h
>
> +void do_notify_resume(struct pt_regs *, void *, __u32);
> +
>
> please add "extern" to each such prototype declaration. (the same is
> true for a handful of other prototypes you've added - please re-review
> and fix them)
>
I was trying to follow other functions declaration in the file.
function declaration without extern :-
http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=f740a1e1bbee2ce8a0b1b97361771db40afc37d2
http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=b7b5113220da95eaa8b75ebd5bbd5278eed122e5
function declaration with extern :-
http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=8cac4294a5e9b036c30d30e2e894e74201ee1c6b
http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=e7d3d48dbf3e517e2e827a2adc6a2f861b16e6a6
http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=feb49274338051ddf11d16f67b08ee6cafb32dbf
But you are emphasizing to use extern for all function declarations.
With current gcc, I think using extern with function declaration is :-
1. Wastage of time
2. Wastage of energy
3. Increase file size with 7 bytes for each extern.
If there is any secret behind using extern in kernel header files.
Please let me know.
Thank you,
Jaswinder Singh.
next prev parent reply other threads:[~2008-07-22 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 17:47 Jaswinder Singh
2008-07-21 18:04 ` Ingo Molnar
2008-07-22 3:18 ` Jaswinder Singh
2008-07-22 5:57 ` Jaswinder Singh [this message]
2008-07-22 19:36 Jaswinder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216706221.2595.8.camel@jaswinder.satnam \
--to=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®