From: Jaswinder Singh <jaswinder@infradead.org>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernelnewbies <kernelnewbies@nl.linux.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 4/22] avr32: Introducing asm/syscalls.h
Date: Thu, 24 Jul 2008 20:37:58 +0530 [thread overview]
Message-ID: <1216912079.15251.6.camel@jaswinder.satnam> (raw)
In-Reply-To: <20080724150911.5bf4372b@hskinnemo-gx745.norway.atmel.com>
Hello Haavard,
On Thu, 2008-07-24 at 15:09 +0200, Haavard Skinnemoen wrote:
> Jaswinder Singh <jaswinder@infradead.org> wrote:
> > +asmlinkage int sys_fork(struct pt_regs);
>
> This should be "struct pt_regs *"
>
> > +asmlinkage int sys_clone(unsigned long, unsigned long,
> > + unsigned long, unsigned long,
> > + struct pt_regs *);
> > +asmlinkage int sys_vfork(struct pt_regs);
>
> Same thing here.
>
> Other than that, looks good to me.
>
If you want to merge this patch in your tree then let me know.
I will fix above issues and send updated patch for avr32 tree.
Thank you,
Jaswinder Singh.
next prev parent reply other threads:[~2008-07-24 15:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 22:21 [PATCH 0/22] " Jaswinder Singh
2008-07-20 22:26 ` [PATCH 1/22] " Jaswinder Singh
2008-07-20 22:27 ` [PATCH 2/22] alpha: " Jaswinder Singh
2008-07-20 22:30 ` [PATCH 3/22] arm: " Jaswinder Singh
2008-07-20 23:20 ` [PATCH 4/22] avr32: " Jaswinder Singh
2008-07-20 23:21 ` [PATCH 5/22] blackfin: " Jaswinder Singh
2008-07-20 23:25 ` [PATCH 6/22] cris: " Jaswinder Singh
2008-07-20 23:31 ` [PATCH 7/22] frv: " Jaswinder Singh
2008-07-20 23:32 ` [PATCH 8/22] h8300: " Jaswinder Singh
2008-07-20 23:33 ` [PATCH 9/22] ia64: " Jaswinder Singh
2008-07-20 23:35 ` [PATCH 10/22] m32r: " Jaswinder Singh
2008-07-20 23:37 ` [PATCH 11/22] m68k: " Jaswinder Singh
2008-07-20 23:39 ` [PATCH 12/22] m68knommu: " Jaswinder Singh
2008-07-20 23:40 ` [PATCH 13/22] mips: " Jaswinder Singh
2008-07-20 23:42 ` [PATCH 14/22] mn10300: " Jaswinder Singh
2008-07-20 23:46 ` [PATCH 15/22] parisc: " Jaswinder Singh
2008-07-20 23:50 ` [PATCH 16/22] s390: " Jaswinder Singh
2008-07-20 23:52 ` [PATCH 17/22] sh: " Jaswinder Singh
2008-07-20 23:53 ` [PATCH 18/22] sparc: " Jaswinder Singh
2008-07-20 23:54 ` [PATCH 19/22] um: " Jaswinder Singh
2008-07-20 23:55 ` [PATCH 20/22] v850: " Jaswinder Singh
2008-07-20 23:58 ` [PATCH 21/22] x86: " Jaswinder Singh
2008-07-21 0:00 ` [PATCH 22/22] xtensa: " Jaswinder Singh
2008-07-21 0:19 ` [PATCH 9/22] ia64: " Matthew Wilcox
2008-07-21 5:19 ` Jaswinder Singh
2008-07-24 13:09 ` [PATCH 4/22] avr32: " Haavard Skinnemoen
2008-07-24 15:07 ` Jaswinder Singh [this message]
2008-07-24 16:49 ` Haavard Skinnemoen
2008-07-21 0:28 ` [PATCH 0/22] " Alexey Dobriyan
2008-07-21 5:45 ` Jaswinder Singh
2008-07-21 5:55 ` Matthew Wilcox
2008-07-21 6:07 ` Jaswinder Singh
2008-07-21 6:16 ` Matthew Wilcox
2008-07-21 6:59 ` Jaswinder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216912079.15251.6.camel@jaswinder.satnam \
--to=jaswinder@infradead.org \
--cc=dwmw2@infradead.org \
--cc=haavard.skinnemoen@atmel.com \
--cc=kernelnewbies@nl.linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®