mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: mingo@redhat.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	bhavna.sarathy@amd.com, robert.richter@amd.com,
	Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH] AMD IOMMU: replace to_pages macro with iommu_num_pages
Date: Fri, 25 Jul 2008 14:57:59 +0200	[thread overview]
Message-ID: <1216990680-1227-3-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1216990680-1227-1-git-send-email-joerg.roedel@amd.com>

This patch removes the to_pages macro from AMD IOMMU code and calls the generic
iommu_num_pages function instead.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/amd_iommu.c |   13 +++++--------
 1 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 7469740..22d7d05 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -29,9 +29,6 @@
 
 #define CMD_SET_TYPE(cmd, t) ((cmd)->data[1] |= ((t) << 28))
 
-#define to_pages(addr, size) \
-	 (round_up(((addr) & ~PAGE_MASK) + (size), PAGE_SIZE) >> PAGE_SHIFT)
-
 #define EXIT_LOOP_COUNT 10000000
 
 static DEFINE_RWLOCK(amd_iommu_devtable_lock);
@@ -185,7 +182,7 @@ static int iommu_flush_pages(struct amd_iommu *iommu, u16 domid,
 		u64 address, size_t size)
 {
 	int s = 0;
-	unsigned pages = to_pages(address, size);
+	unsigned pages = iommu_num_pages(address, size);
 
 	address &= PAGE_MASK;
 
@@ -557,8 +554,8 @@ static struct dma_ops_domain *dma_ops_domain_alloc(struct amd_iommu *iommu,
 	if (iommu->exclusion_start &&
 	    iommu->exclusion_start < dma_dom->aperture_size) {
 		unsigned long startpage = iommu->exclusion_start >> PAGE_SHIFT;
-		int pages = to_pages(iommu->exclusion_start,
-				iommu->exclusion_length);
+		int pages = iommu_num_pages(iommu->exclusion_start,
+					    iommu->exclusion_length);
 		dma_ops_reserve_addresses(dma_dom, startpage, pages);
 	}
 
@@ -767,7 +764,7 @@ static dma_addr_t __map_single(struct device *dev,
 	unsigned int pages;
 	int i;
 
-	pages = to_pages(paddr, size);
+	pages = iommu_num_pages(paddr, size);
 	paddr &= PAGE_MASK;
 
 	address = dma_ops_alloc_addresses(dev, dma_dom, pages);
@@ -802,7 +799,7 @@ static void __unmap_single(struct amd_iommu *iommu,
 	if ((dma_addr == 0) || (dma_addr + size > dma_dom->aperture_size))
 		return;
 
-	pages = to_pages(dma_addr, size);
+	pages = iommu_num_pages(dma_addr, size);
 	dma_addr &= PAGE_MASK;
 	start = dma_addr;
 
-- 
1.5.3.7



  parent reply	other threads:[~2008-07-25 12:58 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25 12:57 [PATCH 0/3] IOMMU: move page number calculation to generic code Joerg Roedel
2008-07-25 12:57 ` [PATCH] add iommu_num_pages helper function Joerg Roedel
2008-07-25 13:15   ` FUJITA Tomonori
2008-07-25 13:21     ` Joerg Roedel
2008-07-25 13:34       ` FUJITA Tomonori
2008-07-25 13:41         ` Joerg Roedel
2008-07-25 13:57           ` FUJITA Tomonori
2008-07-25 14:14             ` Joerg Roedel
2008-07-25 14:32               ` FUJITA Tomonori
2008-07-26 13:41                 ` Ingo Molnar
2008-07-29  1:07                   ` Stephen Rothwell
2008-07-29  1:46                     ` FUJITA Tomonori
2008-07-29  3:56                       ` Stephen Rothwell
2008-07-29  4:38                         ` FUJITA Tomonori
2008-07-29  5:26                           ` David Miller
2008-07-29  5:42                             ` FUJITA Tomonori
2008-07-29  5:24                         ` David Miller
2008-07-29  5:42                           ` FUJITA Tomonori
2008-07-29  6:45                           ` Stephen Rothwell
2008-07-29  9:50                             ` Joerg Roedel
2008-07-29  9:58                               ` FUJITA Tomonori
2008-07-29 10:02                                 ` Joerg Roedel
2008-07-30 22:44                                   ` Benjamin Herrenschmidt
2008-07-31  2:07                                     ` FUJITA Tomonori
2008-07-29 10:10                               ` David Miller
2008-07-29 10:26                                 ` Joerg Roedel
2008-07-29 10:27                                 ` FUJITA Tomonori
2008-07-29 10:31                                   ` Ingo Molnar
2008-07-29 10:33                                     ` David Miller
2008-07-29 12:45                                       ` Stephen Rothwell
2008-07-30 12:18                                 ` Joerg Roedel
2008-07-30 13:16                                   ` FUJITA Tomonori
2008-07-30 14:03                                     ` Joerg Roedel
2008-07-30 18:52                                     ` Joerg Roedel
2008-07-30 22:44                                 ` Benjamin Herrenschmidt
2008-07-29 11:27                     ` Ingo Molnar
2008-07-29 15:45                       ` Jesse Barnes
2008-07-25 12:57 ` Joerg Roedel [this message]
2008-07-25 12:58 ` [PATCH] x86 gart: replace to_pages macro with iommu_num_pages Joerg Roedel
2008-07-26 13:44 ` [PATCH 0/3] IOMMU: move page number calculation to generic code Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216990680-1227-3-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=bhavna.sarathy@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=robert.richter@amd.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome