mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan Wu <cooloney@kernel.org>
To: alan@lxorguk.ukuu.org.uk
Cc: linux-kernel@vger.kernel.org,
	Sonic Zhang <sonic.zhang@analog.com>,
	Bryan Wu <cooloney@kernel.org>
Subject: [PATCH 6/8] Blackfin Serial Driver: Fix bug - Don't call tx_stop in tx_transfer.
Date: Sun, 27 Jul 2008 14:04:05 +0800	[thread overview]
Message-ID: <1217138647-18227-7-git-send-email-cooloney@kernel.org> (raw)
In-Reply-To: <1217138647-18227-1-git-send-email-cooloney@kernel.org>

From: Sonic Zhang <sonic.zhang@analog.com>

Disable irq and return immediately.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
 drivers/serial/bfin_5xx.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
index 31fc8e1..afeff9f 100644
--- a/drivers/serial/bfin_5xx.c
+++ b/drivers/serial/bfin_5xx.c
@@ -301,7 +301,11 @@ static void bfin_serial_tx_chars(struct bfin_serial_port *uart)
 	bfin_serial_mctrl_check(uart);
 
 	if (uart_circ_empty(xmit) || uart_tx_stopped(&uart->port)) {
-		bfin_serial_stop_tx(&uart->port);
+#ifdef CONFIG_BF54x
+		/* Clear TFI bit */
+		UART_PUT_LSR(uart, TFI);
+#endif
+		UART_CLEAR_IER(uart, ETBEI);
 		return;
 	}
 
-- 
1.5.6


  parent reply	other threads:[~2008-07-27  6:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-27  6:03 [PATCH 0/8] Blackfin serial driver updates for 2.6.27 Bryan Wu
2008-07-27  6:04 ` [PATCH 1/8] Blackfin Serial Driver: use __initdata for data, not __init Bryan Wu
2008-07-27  6:04 ` [PATCH 2/8] Blackfin Serial Driver: Fix bug - should suspend/resume/remove all uart ports Bryan Wu
2008-07-27  6:04 ` [PATCH 3/8] Blackfin Serial Driver: trim trailing whitespace -- no functional changes Bryan Wu
2008-07-27  6:04 ` [PATCH 4/8] Blackfin Serial Driver: move common variables out of serial headers and into the serial driver Bryan Wu
2008-07-27  6:04 ` [PATCH 5/8] Blackfin Serial Driver: Remove useless stop Bryan Wu
2008-07-27  6:04 ` Bryan Wu [this message]
2008-07-27  6:04 ` [PATCH 7/8] Blackfin Serial Driver: Fix bug - ircp fails on sir over Blackfin UART Bryan Wu
2008-07-27  6:04 ` [PATCH 8/8] Blackfin Serial Driver: Fix bug - request UART2/3 peripheral mapped interrupts in PIO mode Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217138647-18227-7-git-send-email-cooloney@kernel.org \
    --to=cooloney@kernel.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sonic.zhang@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®