From: Johannes Berg <johannes@sipsolutions.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
robfitz@273k.net, akpm@osdl.org, jikos@jikos.cz, vojtech@suse.cz,
dmonakhov@openvz.org
Subject: Re: [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized
Date: Tue, 29 Jul 2008 08:46:13 +0200 [thread overview]
Message-ID: <1217313973.15381.9.camel@johannes.berg> (raw)
In-Reply-To: <20080729054132.GA5345@anvil.corenet.prv> (sfid-20080729_074139_861345_F4154FB2)
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
On Tue, 2008-07-29 at 01:41 -0400, Dmitry Torokhov wrote:
> > one thing about the drivers/input/mouse/Kconfig patch:
> >
> > The original version contained "select USB", which was later changed
> > to "depends on USB" by Andrew Morton. I saw it reappear as "select USB"
> > in your latest patch, and simply considered it a change back, but
> > maybe it was an oversight?
> >
>
> I am of the opinion that it is OK to "select" high-level subsystems that
> don't have additional dependencies, especially if they are "past" the
> original driver in menuconfig. I don't really like the idea of forcing
> users revisiting earlier sub-menus after they selected a new subsystem
> to see if there are any new options. Plus, if user wants driver for his
> touchpad he does not really care whether it is PS/2 or USB, [s]he just
> wants it to work.
USB tends to have implicit dependencies like the ehci/ohci/uhci
controller though, so it's not going to work like that anyway starting
from a minimal config, and all defconfigs probably have USB anyway.
Therefore, I personally would keep it as "depends on" rather than
"select". YMMV.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-07-29 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 7:37 Henrik Rydberg
2008-07-25 15:42 ` Dmitry Torokhov
2008-07-25 18:25 ` Henrik Rydberg
2008-07-25 18:37 ` Dmitry Torokhov
2008-07-26 7:49 ` Henrik Rydberg
2008-07-29 5:41 ` Dmitry Torokhov
2008-07-29 6:46 ` Johannes Berg [this message]
2008-07-29 7:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217313973.15381.9.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=jikos@jikos.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robfitz@273k.net \
--cc=rydberg@euromail.se \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®