From: David Woodhouse <dwmw2@infradead.org>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: tim.bird@am.sony.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/video/console/promcon.c: fix build error
Date: Sun, 03 Aug 2008 09:56:56 +0100 [thread overview]
Message-ID: <1217753816.2500.13.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20080802230357.GE4856@orion>
On Sun, 2008-08-03 at 03:03 +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
>
> drivers/video/console/promcon.c: fix build error
>
> drivers/video/console/promcon.c:158: error: implicit declaration of
> function 'con_protect_unimap'
>
> Introduced by commit 4744b43431e8613f920c5cba88346756f53c5165
Commit a29ccf6f823a84d89e1c7aaaf221cf7282022024, surely?
And in fact it looks like we could remove those parts of promcon.c
completely if !CONFIG_CONSOLE_TRANSLATIONS. But your patch is certainly
correct, and I've applied it to my 'random-2.6.git' tree which I've
already asked Linus to pull.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2008-08-03 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 23:03 Alexander Beregalov
2008-08-03 8:56 ` David Woodhouse [this message]
2008-08-03 9:21 ` Alexander Beregalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217753816.2500.13.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=a.beregalov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®