From: Jiri Slaby <jirislaby@gmail.com>
To: stable@kernel.org
Cc: greg@kroah.com, chrisw@sous-sol.org,
linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH 2/2] Ath5k: kill tasklets on shutdown
Date: Mon, 4 Aug 2008 11:37:08 +0200 [thread overview]
Message-ID: <1217842628-22714-2-git-send-email-jirislaby@gmail.com> (raw)
In-Reply-To: <1217842628-22714-1-git-send-email-jirislaby@gmail.com>
Don't forget to kill tasklets on stop to not panic if they
fire after freeing some structures.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Nick Kossifidis <mickflemm@gmail.com>
Cc: Luis R. Rodriguez <mcgrof@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/ath5k/base.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index ed51c4a..c5bf8a2 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -2342,6 +2342,9 @@ ath5k_stop_hw(struct ath5k_softc *sc)
mutex_unlock(&sc->lock);
del_timer_sync(&sc->calib_tim);
+ tasklet_kill(&sc->rxtq);
+ tasklet_kill(&sc->txtq);
+ tasklet_kill(&sc->restq);
return ret;
}
--
1.5.6.2
next prev parent reply other threads:[~2008-08-04 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 9:37 [PATCH 1/2] Ath5k: fix memory corruption Jiri Slaby
2008-08-04 9:37 ` Jiri Slaby [this message]
2008-08-04 19:46 ` Greg KH
2008-08-05 8:11 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217842628-22714-2-git-send-email-jirislaby@gmail.com \
--to=jirislaby@gmail.com \
--cc=chrisw@sous-sol.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome