From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933778AbcAKU0N (ORCPT ); Mon, 11 Jan 2016 15:26:13 -0500 Received: from forward7j.cmail.yandex.net ([5.255.227.108]:54919 "EHLO forward7j.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933353AbcAKU0H (ORCPT ); Mon, 11 Jan 2016 15:26:07 -0500 X-Greylist: delayed 1167 seconds by postgrey-1.27 at vger.kernel.org; Mon, 11 Jan 2016 15:26:06 EST From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: David Miller , "fw@strlen.de" Cc: "dvyukov@google.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <20160104.214733.921867451376206917.davem@davemloft.net> References: <20151231132633.GA30790@breakpoint.cc> <20160104.214733.921867451376206917.davem@davemloft.net> Subject: Re: [PATCH] connector: bump skb->users before callback invocation MIME-Version: 1.0 Message-Id: <1218671452542602@web12j.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Mon, 11 Jan 2016 23:03:22 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi everyone Thanks for fixing and quick pushing of this bug. 05.01.2016, 05:47, "David Miller" : > From: Florian Westphal > Date: Thu, 31 Dec 2015 14:26:33 +0100 > >> šDmitry reports memleak with syskaller program. >> šProblem is that connector bumps skb usecount but might not invoke callback. >> >> šSo move skb_get to where we invoke the callback. >> >> šReported-by: Dmitry Vyukov >> šSigned-off-by: Florian Westphal > > Applied and queued up for -stable, thanks.