mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ivan Warren <ivan@vmfacility.fr>
To: schwidefsky@de.ibm.com
Cc: elendil@planet.nl, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org, Ivan Warren <ivan@vmfacility.fr>
Subject: [PATCH] S390 : Set SLI on PSF/PRSSD on Dasd ECKD initialisation
Date: Thu, 14 Aug 2008 20:26:51 +0200	[thread overview]
Message-ID: <1218738411-21828-1-git-send-email-ivan@vmfacility.fr> (raw)
In-Reply-To: <1218726426.25578.0.camel@localhost>

    s390 Dasd ECKD Driver issues a Perform Subsystem Function/Prepare
    for Read Subsystem Data with a length of 16.
    However, some hardware (namely 3990/9390 and some version of ESS)
    only take 12 bytes and therefore, an Incorrect Length indication is
    returned, breaking CCW Command Chaining and leads to a failure to
    initialize the DASD. This patch sets the SLI CCW bit to prevent an
    incorrect length indication to be reported when the control unit
    expects a length of 12 instead of 16.

Signed-off-by: Ivan Warren <ivan@vmfacility.fr>
---
 drivers/s390/block/dasd_eckd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 773b3fe..d644715 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -809,7 +809,7 @@ static int dasd_eckd_read_features(struct dasd_device *device)
 	ccw = cqr->cpaddr;
 	ccw->cmd_code = DASD_ECKD_CCW_PSF;
 	ccw->count = sizeof(struct dasd_psf_prssd_data);
-	ccw->flags |= CCW_FLAG_CC;
+	ccw->flags |= CCW_FLAG_CC|CCW_FLAG_SLI;
 	ccw->cda = (__u32)(addr_t) prssdp;
 
 	/* Read Subsystem Data - feature codes */
-- 
1.5.6.3


  reply	other threads:[~2008-08-14 18:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08 18:46 [Patch 2.6] s390 - Allow ECKD devices to be used with older controllers and emulation Ivan Warren
2008-08-13 23:07 ` Fwd: " Frans Pop
2008-08-14 15:07   ` Martin Schwidefsky
2008-08-14 18:26     ` Ivan Warren [this message]
2008-08-15 14:15       ` [PATCH] S390 : Set SLI on PSF/PRSSD on Dasd ECKD initialisation Stefan Weinhuber
2008-08-18 17:08         ` Ivan Warren
2008-08-18 17:56           ` Frans Pop
2008-08-21 16:32             ` Stefan Weinhuber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218738411-21828-1-git-send-email-ivan@vmfacility.fr \
    --to=ivan@vmfacility.fr \
    --cc=elendil@planet.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome