From: Joerg Roedel <joerg.roedel@amd.com>
To: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com
Cc: linux-kernel@vger.kernel.org, Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH] fix build error in kernel/rcuclassic.c with latest tip/master
Date: Tue, 19 Aug 2008 11:50:52 +0200 [thread overview]
Message-ID: <1219139452-7435-1-git-send-email-joerg.roedel@amd.com> (raw)
This patch fixes the following build error for me:
CC kernel/rcuclassic.o
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c: In function ‘__rcu_process_callbacks’:
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c:561: error: ‘flags’ undeclared (first use in this function)
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c:561: error: (Each undeclared identifier is reported only once
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c:561: error: for each function it appears in.)
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c:561: warning: type defaults to ‘int’ in declaration of ‘__dummy2’
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c:561: warning: comparison of distinct pointer types lacks a cast
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c:566: warning: type defaults to ‘int’ in declaration of ‘__dummy2’
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c:566: warning: comparison of distinct pointer types lacks a cast
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c: In function ‘rcu_init_percpu_data’:
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c:713: warning: comparison of distinct pointer types lacks a cast
/data2/repos/tip/linux.trees.git/kernel/rcuclassic.c:721: warning: comparison of distinct pointer types lacks a cast
make[2]: *** [kernel/rcuclassic.o] Error 1
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
kernel/rcuclassic.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
index c6b6cf5..2f193e1 100644
--- a/kernel/rcuclassic.c
+++ b/kernel/rcuclassic.c
@@ -557,6 +557,8 @@ static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp,
local_irq_enable();
if (rcu_batch_after(rdp->batch, rcp->pending)) {
+ unsigned long flags;
+
/* and start it/schedule start if it's a new batch */
spin_lock_irqsave(&rcp->lock, flags);
if (rcu_batch_after(rdp->batch, rcp->pending)) {
@@ -708,7 +710,7 @@ void rcu_check_callbacks(int cpu, int user)
static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp,
struct rcu_data *rdp)
{
- long flags;
+ unsigned long flags;
spin_lock_irqsave(&rcp->lock, flags);
memset(rdp, 0, sizeof(*rdp));
--
1.5.3.7
next reply other threads:[~2008-08-19 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 9:50 Joerg Roedel [this message]
2008-08-19 9:58 ` Ingo Molnar
2008-08-19 14:24 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219139452-7435-1-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®