Re: [PATCH] sched: disable hrtick implementation

[Peter Zijlstra <peterz@infradead.org>]

On Tue, 2008-08-19 at 15:54 -0700, Justin Madru wrote:
> The hrtick implementation in 2.6.25 and .26 has been known to cause boot
> problems with at least Intel GMA cards. see:
> 
>  https://bugs.freedesktop.org/show_bug.cgi?id=15602
>  http://bugzilla.kernel.org/show_bug.cgi?id=10892
> 
> A full fix to hrtick went into 2.6.27 
> (31656519e132f6612584815f128c83976a9aaaef),
> but that fix is too intrusive to backport. Henceforth, we default to 
> disable hrtick.

Thing is, I'm still not understanding how, or if, the old code is wrong.

That said, this will paper over the problem just fine, and as its old
kernels we're talking about I don't particularly care.

Just occured to me that a Kconfig change that always makes
CONFIG_SCHED_HRTICK not set will also do.

> Signed-off-by: Justin Madru <jdm64@gawab.com>
> Tested-by: Justin Madru <jdm64@gawab.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> 
> --- a/kernel/sched_features.h
> +++ b/kernel/sched_features.h
> @@ -4,7 +4,7 @@
>  SCHED_FEAT(AFFINE_WAKEUPS, 1)
>  SCHED_FEAT(CACHE_HOT_BUDDY, 1)
>  SCHED_FEAT(SYNC_WAKEUPS, 1)
> -SCHED_FEAT(HRTICK, 1)
> +SCHED_FEAT(HRTICK, 0)
>  SCHED_FEAT(DOUBLE_TICK, 0)
>  SCHED_FEAT(NORMALIZED_SLEEPER, 1)
>  SCHED_FEAT(DEADLINE, 1)
>