mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org
Cc: robert.richter@amd.com, oprofile-list@lists.sourceforge.net,
	Andi Kleen <ak@linux.intel.com>
Subject: [PATCH] oprofile: Don't report Nehalem as core_2
Date: Wed, 20 Aug 2008 18:40:32 +0200	[thread overview]
Message-ID: <1219250433-25516-4-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1219250433-25516-3-git-send-email-andi@firstfloor.org>

From: Andi Kleen <ak@linux.intel.com>

This essentially reverts Linus' earlier 4b9f12a3779c548b68bc9af7d94030868ad3aa1b
commit. Nehalem is not core_2, so it shouldn't be reported as such.
However with the earlier arch perfmon patch it will fall back to
arch perfmon mode now, so there is no need to fake it as core_2.
The only drawback is that Linus will need to patch the arch perfmon
support into his oprofile binary now, but I think he can do that.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 arch/x86/oprofile/nmi_int.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c
index 6438c32..669a713 100644
--- a/arch/x86/oprofile/nmi_int.c
+++ b/arch/x86/oprofile/nmi_int.c
@@ -418,9 +418,6 @@ static int __init ppro_init(char **cpu_type)
 	case 15: case 23:
 		*cpu_type = "i386/core_2";
 		break;
-	case 26:
-		*cpu_type = "i386/core_2";
-		break;
 	default:
 		/* Unknown */
 		return 0;
-- 
1.5.6


  reply	other threads:[~2008-08-20 16:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20 16:40 oprofile: Implement Intel architectural perfmon Andi Kleen
2008-08-20 16:40 ` [PATCH] oprofile: drop const in num counters field Andi Kleen
2008-08-20 16:40   ` [PATCH] oprofile: Implement Intel architectural perfmon support Andi Kleen
2008-08-20 16:40     ` Andi Kleen [this message]
2008-08-20 16:40       ` [PATCH] oprofile: document undocumented oprofile.p4force argument Andi Kleen
2008-09-25 20:10         ` Robert Richter
2008-09-25 20:05       ` [PATCH] oprofile: Don't report Nehalem as core_2 Robert Richter
2008-09-25 20:00     ` [PATCH] oprofile: Implement Intel architectural perfmon support Robert Richter
2008-09-26  0:44       ` Andi Kleen
2008-09-26  3:23         ` Robert Richter
2008-09-26 23:09           ` Andi Kleen
2008-09-28  7:33             ` Robert Richter
2008-09-25 19:32 ` oprofile: Implement Intel architectural perfmon Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219250433-25516-4-git-send-email-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oprofile-list@lists.sourceforge.net \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome