From: Ian Campbell <ijc@hellion.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
stable@kernel.org, jayakumar.lkml@gmail.com, npiggin@suse.de,
a.p.zijlstra@chello.nl, hugh@veritas.com, hannes@saeurebad.de,
jeremy@goop.org, kel@otaku42.de, armbru@redhat.com
Subject: Re: [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB
Date: Wed, 20 Aug 2008 20:40:54 +0100 [thread overview]
Message-ID: <1219261254.3996.54.camel@localhost.localdomain> (raw)
In-Reply-To: <20080820123056.8f0c9d3f.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
On Wed, 2008-08-20 at 12:30 -0700, Andrew Morton wrote:
> On Wed, 20 Aug 2008 19:57:53 +0100 Ian Campbell <ijc@hellion.org.uk>
> wrote:
> }
> > +#ifdef CONFIG_FB_DEFERRED_IO
> > + if (info->fbdefio)
> > + fb_deferred_io_open(info, inode, file);
> > +#endif
>
> eww, hacky, but drivers/video/fbmem.c already got hacky:
>
> #ifdef CONFIG_FB_DEFERRED_IO
> .fsync = fb_deferred_io_fsync,
> #endif
>
> so it's not an original sin.
That's what I figured.
> Does it work?
Yep.
Ian.
--
Ian Campbell
Nobody knows what goes between his cold toes and his warm ears.
-- Roy Harper
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-08-20 19:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 6:02 Ian Campbell
2008-08-19 6:38 ` Andrew Morton
2008-08-19 7:13 ` Peter Zijlstra
2008-08-20 8:13 ` Ian Campbell
2008-08-20 8:37 ` Andrew Morton
2008-08-20 18:57 ` Ian Campbell
2008-08-20 19:30 ` Andrew Morton
2008-08-20 19:40 ` Ian Campbell [this message]
2008-08-20 19:50 ` Andrew Morton
2008-08-20 23:11 ` Jaya Kumar
2008-08-20 8:46 ` Jaya Kumar
2008-08-20 12:27 ` Markus Armbruster
2008-08-20 18:47 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219261254.3996.54.camel@localhost.localdomain \
--to=ijc@hellion.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=armbru@redhat.com \
--cc=hannes@saeurebad.de \
--cc=hugh@veritas.com \
--cc=jayakumar.lkml@gmail.com \
--cc=jeremy@goop.org \
--cc=kel@otaku42.de \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome