mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <holtmann@linux.intel.com>
To: Jim Meyering <meyering@redhat.com>
Cc: linux-kernel@vger.kernel.org, Sujith.Manoharan@atheros.com,
	linville@tuxdriver.com
Subject: Re: [PATCH] ath9k: add harmlessly-omitted braces
Date: Sat, 23 Aug 2008 12:02:42 +0200	[thread overview]
Message-ID: <1219485762.7591.476.camel@violet.holtmann.net> (raw)
In-Reply-To: <87zln4rzce.fsf@rho.meyering.net>

Hi Jim

> Alternatively, you could remove the nowadays-useless
> "if-before-kfree" test and leave the sometimes-redundant
> assignment as-is: unconditional.

actually the later one is preferred. Just remove the NULL check.

Regards

Marcel



  reply	other threads:[~2008-08-23 10:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-23  6:49 Jim Meyering
2008-08-23 10:02 ` Marcel Holtmann [this message]
2008-08-23 10:25   ` [PATCH] ath9k: remove useless if-before-kfree; correct misleading indentation Jim Meyering
2008-08-23 11:03     ` Marcel Holtmann
2008-08-23 11:28       ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219485762.7591.476.camel@violet.holtmann.net \
    --to=holtmann@linux.intel.com \
    --cc=Sujith.Manoharan@atheros.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=meyering@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®