From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D989C433DB for ; Tue, 5 Jan 2021 08:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E45FB2255F for ; Tue, 5 Jan 2021 08:44:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727605AbhAEIon (ORCPT ); Tue, 5 Jan 2021 03:44:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbhAEIom (ORCPT ); Tue, 5 Jan 2021 03:44:42 -0500 Received: from yawp.biot.com (yawp.biot.com [IPv6:2a01:4f8:10a:8e::fce2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 456C5C061793 for ; Tue, 5 Jan 2021 00:44:02 -0800 (PST) Received: from debian-spamd by yawp.biot.com with sa-checked (Exim 4.93) (envelope-from ) id 1kwhwd-00Bkrf-R8 for linux-kernel@vger.kernel.org; Tue, 05 Jan 2021 09:44:00 +0100 Received: from [85.234.217.28] (helo=[10.0.1.5]) by yawp.biot.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kwhwd-00Bkrb-M4; Tue, 05 Jan 2021 09:43:59 +0100 Subject: Re: [PATCH v3 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller To: Mark Brown Cc: Rob Herring , Birger Koblitz , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210101132432.2785663-1-bert@biot.com> <20210101132432.2785663-2-bert@biot.com> <20210104213131.GL5645@sirena.org.uk> From: Bert Vermeulen Message-ID: <121d9dc6-7993-d43b-291f-74dd943f4fc6@biot.com> Date: Tue, 5 Jan 2021 09:43:59 +0100 MIME-Version: 1.0 In-Reply-To: <20210104213131.GL5645@sirena.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/4/21 10:31 PM, Mark Brown wrote: > On Fri, Jan 01, 2021 at 02:24:31PM +0100, Bert Vermeulen wrote: > >> + compatible: >> + const: realtek,rtl-spi > > This is still just using rtl-spi as the compatible string, please > address the feedback on the previous version. Mark, The rtl prefix really is as close as it gets. This is being developed on RTL838x and RTL839x, but the driver very likely also works on RTL8196C and RTL93xx series. There's no difference to the SPI block in those SoCs. Do you really want a different per-series compatible when the "IP block" was just copy-pasted between series in hardware? -- Bert Vermeulen bert@biot.com