mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: linux-fsdevel-owner@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Adrian Hunter <ext-adrian.hunter@nokia.com>
Subject: [PATCH] UBIFS: introduce LEB overhead
Date: Sun, 31 Aug 2008 17:52:44 +0300	[thread overview]
Message-ID: <1220194366-12731-11-git-send-email-dedekind@infradead.org> (raw)
In-Reply-To: <1220194366-12731-1-git-send-email-dedekind@infradead.org>

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

This is a preparational patch for the following statfs()
report fix.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 fs/ubifs/super.c |    6 ++++++
 fs/ubifs/ubifs.h |    5 +++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 1018053..be23fd3 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -530,6 +530,12 @@ static int init_constants_early(struct ubifs_info *c)
 	c->dead_wm = ALIGN(MIN_WRITE_SZ, c->min_io_size);
 	c->dark_wm = ALIGN(UBIFS_MAX_NODE_SZ, c->min_io_size);
 
+	/*
+	 * Calculate how many bytes would be wasted at the end of LEB if it was
+	 * fully filled with data nodes of maximum size. This is used in
+	 * calculations when reporting free space.
+	 */
+	c->leb_overhead = c->leb_size % UBIFS_MAX_DATA_NODE_SZ;
 	return 0;
 }
 
diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h
index 681d46e..57e5854 100644
--- a/fs/ubifs/ubifs.h
+++ b/fs/ubifs/ubifs.h
@@ -995,6 +995,9 @@ struct ubifs_mount_opts {
  * @max_idx_node_sz: maximum indexing node aligned on 8-bytes boundary
  * @max_inode_sz: maximum possible inode size in bytes
  * @max_znode_sz: size of znode in bytes
+ *
+ * @leb_overhead: how many bytes are wasted in an LEB when it is filled with
+ *                data nodes of maximum size - used in free space reporting
  * @dead_wm: LEB dead space watermark
  * @dark_wm: LEB dark space watermark
  * @block_cnt: count of 4KiB blocks on the FS
@@ -1226,6 +1229,8 @@ struct ubifs_info {
 	int max_idx_node_sz;
 	long long max_inode_sz;
 	int max_znode_sz;
+
+	int leb_overhead;
 	int dead_wm;
 	int dark_wm;
 	int block_cnt;
-- 
1.5.4.1


  parent reply	other threads:[~2008-08-31 13:17 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-31 14:52 UBIFS updates for 2.6.27 Artem Bityutskiy
2008-08-31 14:32 ` Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: fix zero-length truncations Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: always read hashed-key nodes under TNC mutex Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: allow for racing between GC and TNC Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: do not update min_idx_lebs in stafs Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: push empty flash hack down Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: remove incorrect index space check Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: improve statfs reporting Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: fix assertion Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: add forgotten gc_idx_lebs component Artem Bityutskiy
2008-08-31 14:52 ` Artem Bityutskiy [this message]
2008-08-31 14:52 ` [PATCH] UBIFS: improve statfs reporting even more Artem Bityutskiy
2008-08-31 14:52 ` [PATCH] UBIFS: fill f_fsid Artem Bityutskiy
2008-09-01  9:43   ` David Woodhouse
2008-09-01 11:16     ` Artem Bityutskiy
2008-09-01 11:28       ` David Woodhouse
2008-09-01 11:43         ` Artem Bityutskiy
2008-09-01 11:50           ` David Woodhouse
2008-09-01 11:56             ` Artem Bityutskiy
2008-09-01 15:01     ` Christoph Hellwig
2008-09-02  7:03       ` Artem Bityutskiy
2008-09-02 17:09         ` Andreas Dilger
2008-09-02 17:29           ` David Woodhouse
2008-09-02 19:13             ` Andreas Dilger
2008-09-02 19:32               ` David Woodhouse
2008-09-02 21:02           ` Christoph Hellwig
2008-09-02 21:26             ` David Woodhouse
2008-09-02 21:48               ` Christoph Hellwig
2008-09-02 22:12                 ` David Woodhouse
2008-09-03  6:20               ` Artem Bityutskiy
2008-09-02 22:32             ` David Woodhouse
2008-09-03  9:44     ` Artem Bityutskiy
2008-09-03 10:14       ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220194366-12731-11-git-send-email-dedekind@infradead.org \
    --to=dedekind@infradead.org \
    --cc=ext-adrian.hunter@nokia.com \
    --cc=linux-fsdevel-owner@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®