From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753870AbYIJSP0 (ORCPT ); Wed, 10 Sep 2008 14:15:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751377AbYIJSPR (ORCPT ); Wed, 10 Sep 2008 14:15:17 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:46266 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbYIJSPP (ORCPT ); Wed, 10 Sep 2008 14:15:15 -0400 Subject: Re: 2.6.26.4 hard-unsafe lock order detected (drm-related?) From: Peter Zijlstra To: Marcus Furlong Cc: linux-kernel@vger.kernel.org, Dave Airlie In-Reply-To: References: Content-Type: text/plain Date: Wed, 10 Sep 2008 20:15:10 +0200 Message-Id: <1221070510.4415.207.camel@twins.programming.kicks-ass.net> Mime-Version: 1.0 X-Mailer: Evolution 2.23.91 (2.23.91-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2008-09-10 at 17:48 +0100, Marcus Furlong wrote: > Hi, > > Just found this in dmesg, if any more info is needed let me know. Dave, have you ever seen this one before? Marcus, can you reproduce? - if so, could you try .27-rc6 to see if it is still valid? > [18255.940781] ====================================================== > [18255.940789] [ INFO: hard-safe -> hard-unsafe lock order detected ] > [18255.940792] 2.6.26.4 #1 > [18255.940794] ------------------------------------------------------ > [18255.940797] swapper/0 [HC0[0]:SC1[2]:HE0:SE0] is trying to acquire: > [18255.940800] (&dev->lock.spinlock){-+..}, at: [] > drm_lock_take+0x1c/0xc0 [drm] > [18255.940815] > [18255.940816] and this task is already holding: > [18255.940818] (&dev->tasklet_lock){++..}, at: [] > drm_locked_tasklet_func+0x1e/0x90 [drm] > [18255.940831] which would create a new lock dependency: > [18255.940833] (&dev->tasklet_lock){++..} -> (&dev->lock.spinlock){-+..} > [18255.940840] > [18255.940841] but this new dependency connects a hard-irq-safe lock: > [18255.940843] (&dev->tasklet_lock){++..} > [18255.940846] ... which became hard-irq-safe at: > [18255.940848] [] __lock_acquire+0x82d/0xfb0 > [18255.940856] [] lock_acquire+0x61/0x80 > [18255.940862] [] _spin_lock_irqsave+0x43/0x60 > [18255.940869] [] drm_locked_tasklet+0x4d/0xa0 [drm] > [18255.940880] [] i915_driver_irq_handler+0x1c3/0x1f0 [i915] > [18255.940888] [] handle_IRQ_event+0x28/0x60 > [18255.940892] [] handle_fasteoi_irq+0x78/0xf0 > [18255.940892] [] do_IRQ+0x79/0xc0 > [18255.940892] [] 0xffffffff > [18255.940892] > [18255.940892] to a hard-irq-unsafe lock: > [18255.940892] (&dev->lock.spinlock){-+..} > [18255.940892] ... which became hard-irq-unsafe at: > [18255.940892] ... [] __lock_acquire+0x606/0xfb0 > [18255.940892] [] lock_acquire+0x61/0x80 > [18255.940892] [] _spin_lock_bh+0x3b/0x50 > [18255.940892] [] drm_lock+0x8e/0x310 [drm] > [18255.940892] [] drm_ioctl+0x1b9/0x2f0 [drm] > [18255.940892] [] vfs_ioctl+0x6b/0x80 > [18255.940892] [] do_vfs_ioctl+0x57/0x2b0 > [18255.940892] [] sys_ioctl+0x39/0x60 > [18255.940892] [] sysenter_past_esp+0x6a/0xb1 > [18255.940892] [] 0xffffffff > [18255.940892] > [18255.940892] other info that might help us debug this: > [18255.940892] > [18255.940892] 1 lock held by swapper/0: > [18255.940892] #0: (&dev->tasklet_lock){++..}, at: [] > drm_locked_tasklet_func+0x1e/0x90 [drm] > [18255.940892] > [18255.940892] the hard-irq-safe lock's dependencies: > [18255.940892] -> (&dev->tasklet_lock){++..} ops: 0 { > [18255.940892] initial-use at: > [18255.940892] [] > __lock_acquire+0x11d/0xfb0 > [18255.940892] [] > lock_acquire+0x61/0x80 > [18255.940892] [] > _spin_lock_irqsave+0x43/0x60 > [18255.940892] [] > drm_locked_tasklet+0x4d/0xa0 [drm] > [18255.940892] [] > i915_driver_irq_handler+0x1c3/0x1f0 [i915] > [18255.940892] [] > handle_IRQ_event+0x28/0x60 > [18255.940892] [] > handle_fasteoi_irq+0x78/0xf0 > [18255.940892] [] > do_IRQ+0x79/0xc0 > [18255.940892] [] 0xffffffff > [18255.940892] in-hardirq-W at: > [18255.940892] [] > __lock_acquire+0x82d/0xfb0 > [18255.940892] [] > lock_acquire+0x61/0x80 > [18255.940892] [] > _spin_lock_irqsave+0x43/0x60 > [18255.940892] [] > drm_locked_tasklet+0x4d/0xa0 [drm] > [18255.940892] [] > i915_driver_irq_handler+0x1c3/0x1f0 [i915] > [18255.940892] [] > handle_IRQ_event+0x28/0x60 > [18255.940892] [] > handle_fasteoi_irq+0x78/0xf0 > [18255.940892] [] > do_IRQ+0x79/0xc0 > [18255.940892] [] 0xffffffff > [18255.940892] in-softirq-W at: > [18255.940892] [] > __lock_acquire+0x4bf/0xfb0 > [18255.940892] [] > lock_acquire+0x61/0x80 > [18255.940892] [] > _spin_lock_irqsave+0x43/0x60 > [18255.940892] [] > drm_locked_tasklet_func+0x1e/0x90 [drm] > [18255.940892] [] > tasklet_hi_action+0x5b/0xd0 > [18255.940892] [] > __do_softirq+0x74/0xe0 > [18255.940892] [] > do_softirq+0x95/0xd0 > [18255.940892] [] 0xffffffff > [18255.940892] } > [18255.940892] ... key at: [] __key.23164+0x0/0xffff90cb [drm] > [18255.940892] > [18255.940892] the hard-irq-unsafe lock's dependencies: > [18255.940892] -> (&dev->lock.spinlock){-+..} ops: 0 { > [18255.940892] initial-use at: > [18255.940892] [] > __lock_acquire+0x11d/0xfb0 > [18255.940892] [] > lock_acquire+0x61/0x80 > [18255.940892] [] > _spin_lock_bh+0x3b/0x50 > [18255.940892] [] > drm_lock+0x8e/0x310 [drm] > [18255.940892] [] > drm_ioctl+0x1b9/0x2f0 [drm] > [18255.940892] [] > vfs_ioctl+0x6b/0x80 > [18255.940892] [] > do_vfs_ioctl+0x57/0x2b0 > [18255.940892] [] > sys_ioctl+0x39/0x60 > [18255.940892] [] > sysenter_past_esp+0x6a/0xb1 > [18255.940892] [] 0xffffffff > [18255.940892] in-softirq-W at: > [18255.940892] [] > __lock_acquire+0x4bf/0xfb0 > [18255.940892] [] > lock_acquire+0x61/0x80 > [18255.940892] [] > _spin_lock_bh+0x3b/0x50 > [18255.940892] [] > drm_lock_take+0x1c/0xc0 [drm] > [18255.940892] [] > drm_locked_tasklet_func+0x3a/0x90 [drm] > [18255.940892] [] > tasklet_hi_action+0x5b/0xd0 > [18255.940892] [] > __do_softirq+0x74/0xe0 > [18255.940892] [] > do_softirq+0x95/0xd0 > [18255.940892] [] 0xffffffff > [18255.940892] hardirq-on-W at: > [18255.940892] [] > __lock_acquire+0x606/0xfb0 > [18255.940892] [] > lock_acquire+0x61/0x80 > [18255.940892] [] > _spin_lock_bh+0x3b/0x50 > [18255.940892] [] > drm_lock+0x8e/0x310 [drm] > [18255.940892] [] > drm_ioctl+0x1b9/0x2f0 [drm] > [18255.940892] [] > vfs_ioctl+0x6b/0x80 > [18255.940892] [] > do_vfs_ioctl+0x57/0x2b0 > [18255.940892] [] > sys_ioctl+0x39/0x60 > [18255.940892] [] > sysenter_past_esp+0x6a/0xb1 > [18255.940892] [] 0xffffffff > [18255.940892] } > [18255.940892] ... key at: [] __key.23165+0x0/0xffff90d3 [drm] > [18255.940892] > [18255.940892] stack backtrace: > [18255.940892] Pid: 0, comm: swapper Not tainted 2.6.26.4 #1 > [18255.940892] [] check_usage+0x252/0x260 > [18255.940892] [] __lock_acquire+0xae8/0xfb0 > [18255.940892] [] lock_acquire+0x61/0x80 > [18255.940892] [] ? drm_lock_take+0x1c/0xc0 [drm] > [18255.940892] [] _spin_lock_bh+0x3b/0x50 > [18255.940892] [] ? drm_lock_take+0x1c/0xc0 [drm] > [18255.940892] [] drm_lock_take+0x1c/0xc0 [drm] > [18255.940892] [] drm_locked_tasklet_func+0x3a/0x90 [drm] > [18255.940892] [] tasklet_hi_action+0x5b/0xd0 > [18255.940892] [] __do_softirq+0x74/0xe0 > [18255.940892] [] do_softirq+0x95/0xd0 > [18255.940892] [] ? handle_fasteoi_irq+0x0/0xf0 > [18255.940892] [] irq_exit+0x86/0xa0 > [18255.940892] [] do_IRQ+0x80/0xc0 > [18255.940892] [] common_interrupt+0x2e/0x34 > [18255.940892] [] ? tick_setup_oneshot+0x28/0x40 > [18255.940892] [] ? acpi_idle_enter_bm+0x297/0x306 > [18255.940892] [] cpuidle_idle_call+0x6b/0xc0 > [18255.940892] [] ? cpuidle_idle_call+0x0/0xc0 > [18255.940892] [] cpu_idle+0x60/0xf0 > [18255.940892] [] rest_init+0x62/0x70 > [18255.940892] ======================= > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/