From: Timur Tabi <timur@freescale.com>
To: dan.j.williams@intel.com, haavard.skinnemoen@atmel.com,
linux-kernel@vger.kernel.org
Subject: [PATCH] dmatest: properly handle duplicate DMA channels
Date: Thu, 18 Sep 2008 10:21:19 -0500 [thread overview]
Message-ID: <1221751279-24936-1-git-send-email-timur@freescale.com> (raw)
Update the the dmatest driver so that it handles duplicate DMA channels
properly.
When a DMA client is notified of an available DMA channel, it must check if it
has already allocated resources for that channel. If so, it should return
DMA_DUP. This can happen, for example, if a DMA driver calls
dma_async_device_register() more than once.
Signed-off-by: Timur Tabi <timur@freescale.com>
---
drivers/dma/dmatest.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index a08d197..2689d90 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -321,10 +321,15 @@ static void dmatest_cleanup_channel(struct dmatest_chan *dtc)
static enum dma_state_client dmatest_add_channel(struct dma_chan *chan)
{
- struct dmatest_chan *dtc;
+ struct dmatest_chan *dtc, *_dtc;
struct dmatest_thread *thread;
unsigned int i;
+ /* Have we already been told about this channel? */
+ list_for_each_entry_safe(dtc, _dtc, &dmatest_channels, node)
+ if (dtc->chan == chan)
+ return DMA_DUP;
+
dtc = kmalloc(sizeof(struct dmatest_chan), GFP_ATOMIC);
if (!dtc) {
pr_warning("dmatest: No memory for %s\n", chan->dev.bus_id);
--
1.5.5
next reply other threads:[~2008-09-18 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 15:21 Timur Tabi [this message]
2008-09-18 15:32 ` Haavard Skinnemoen
2008-09-18 15:34 ` Timur Tabi
2008-09-18 15:48 ` Haavard Skinnemoen
2008-09-19 23:31 ` Andrew Morton
2008-09-20 12:42 ` Haavard Skinnemoen
2008-09-20 21:40 ` Dan Williams
2008-09-20 22:20 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221751279-24936-1-git-send-email-timur@freescale.com \
--to=timur@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome