From: Johannes Berg <johannes@sipsolutions.net>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Ivo van Doorn <ivdoorn@gmail.com>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] rfkill: clarify usage of rfkill_force_state() and rfkill->get_state()
Date: Thu, 18 Sep 2008 18:45:39 +0200 [thread overview]
Message-ID: <1221756339.9262.86.camel@johannes.berg> (raw)
In-Reply-To: <20080918164339.GM1583@khazad-dum.debian.net> (sfid-20080918_184349_935626_1261357F)
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Thu, 2008-09-18 at 13:43 -0300, Henrique de Moraes Holschuh wrote:
> Now it must do something like this in pseudo-code:
>
> 1. if (the bit is disabled (i.e. SW rfkill is NOT ACTIVE)) {
> rfkill-SW-status = disabled;
> } else if (the bit is enabled (i.e. SW rfkill is ACTIVE)) {
> if (tx power off is NOT ACTIVE)
> rfkill-SW-status = enabled;
> else
> rfkill-SW-status = whatever the user asked
> }
>
> THEN, it should use rfkill-sw-status, along with the hw rfkill line status,
> to synthesize the state it must pass to rfkill_force_status().
>
> ICK. Of course, if the driver has another way to implement txpower off that
> does not clash with sw rfkill, the above is unneeded.
Why are we not handling soft-rfkill in mac80211 entirely?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-09-18 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080918145236.GJ1583@khazad-dum.debian.net>
2008-09-18 15:19 ` Henrique de Moraes Holschuh
2008-09-18 15:24 ` Ivo van Doorn
2008-09-18 16:43 ` Henrique de Moraes Holschuh
2008-09-18 16:45 ` Johannes Berg [this message]
2008-09-18 17:32 ` Ivo van Doorn
2008-09-18 17:52 ` Johannes Berg
2008-09-18 18:12 ` Ivo van Doorn
2008-09-18 17:40 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221756339.9262.86.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=hmh@hmh.eng.br \
--cc=ivdoorn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®