Re: [PATCH] soc: mediatek: mtk-mutex: Fix confusing usage of MUTEX_MOD2

["Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>]

Hi Angelo,

Thanks for the review.

On Mon, 2025-06-23 at 11:35 +0200, AngeloGioacchino Del Regno wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 20/06/25 04:40, Jason-JH Lin ha scritto:
> > The usage of MUTEX_MOD1 and MUTEX_MOD2 for calculating mod settings
> > over 32 has been confusing. To improve consistency and clarity,
> > these
> > defines need to fit into the same MUTEX_MOD define as possible.
> > 
> > However, MUTEX_MOD1 cannot be directly used for all SoCs because,
> > for example, the mod1 register (0x34) of MT2712 is not adjacent to
> > its mod0 register (0x2c). To address this, a `mutex_mod1_reg` field
> > is introduced in the mutex driver data structure. This allows all
> > SoCs to use a unified MUTEX_MOD to determine their register
> > offsets.
> > 
> > With this change, the separate usage of MUTEX_MOD1 and MUTEX_MOD2
> > is
> > eliminated, simplifying the logic for obtaining offsets and mod
> > IDs.
> 
> Yeah, okay, that makes sense, but...
> 
> > 
> > Fixes: e1e4f7fea375 ("soc / drm: mediatek: Move mtk mutex driver to
> > soc folder")
> 
> ...this is an improvement, it's not a fix, so please drop the Fixes
> tag.
> 

I'll drop this and send the v2.

Regards,
Jason-JH Lin

> > Signed-off-by: Jason-JH Lin <jason-jh.lin@mediatek.com>
> 
> After which:
> 
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com>
> 
>