From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, serue@linux.vnet.ibm.com,
safford@watson.ibm.com, debora@linux.vnet.ibm.com
Subject: Re: [PATCH 3/4][resubmit] TPM: rcu locking
Date: Tue, 23 Sep 2008 17:27:34 -0400 [thread overview]
Message-ID: <1222205254.9218.30.camel@localhost.localdomain> (raw)
In-Reply-To: <20080923150129.0d8356e8@bike.lwn.net>
On Tue, 2008-09-23 at 15:01 -0600, Jonathan Corbet wrote:
> On Tue, 23 Sep 2008 17:19:33 -0300
> Rajiv Andrade <srajiv@linux.vnet.ibm.com> wrote:
>
> > Protects tpm_chip_list when transversing it.
>
> It all looks like it should work (though it might make sense to include
> <linux/rcupdate.h> and <linux/rculist.h>. But I have to ask: do you
> really need the added complexity of RCU here? I suspect that TPM
> devices don't come and go very often...once most of us have ripped it
> out, we tend to leave it out...:)
>
> jon
True, the RCU locking is overkill for the current TPM code. It will be
used in the integrity-tpm-internal-interface patch to resolve the
locking issue that Christoph Helwig noted for the case when the TPM
driver is built as a module, which it shouldn't be, instead of being
built-in.
Mimi Zohar
next prev parent reply other threads:[~2008-09-23 21:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 17:19 [PATCH 0/4] BKL removed, RCU addition and pnp remove Rajiv Andrade
2008-09-23 17:19 ` [PATCH 1/4] TPM: update char dev BKL pushdown Rajiv Andrade
2008-09-23 20:58 ` Jonathan Corbet
2008-09-24 13:14 ` Rajiv Andrade
2008-09-23 17:19 ` [PATCH 2/4] TPM: num_opens to is_open variable change Rajiv Andrade
2008-09-23 17:19 ` [PATCH 3/4] TPM: rcu locking Rajiv Andrade
2008-09-23 18:19 ` Paul E. McKenney
2008-09-23 20:18 ` Rajiv Andrade
2008-09-23 20:27 ` Paul E. McKenney
2008-09-25 13:36 ` Serge E. Hallyn
2008-09-25 14:33 ` Paul E. McKenney
2008-09-25 14:59 ` Serge E. Hallyn
2008-09-23 20:19 ` [PATCH 3/4][resubmit] " Rajiv Andrade
2008-09-23 21:01 ` Jonathan Corbet
2008-09-23 21:27 ` Mimi Zohar [this message]
2008-09-24 13:10 ` Rajiv Andrade
2008-09-25 13:39 ` Serge E. Hallyn
2008-09-25 13:29 ` [PATCH 3/4] " Serge E. Hallyn
2008-09-23 17:19 ` [PATCH 4/4] TPM: addition of pnp remove Rajiv Andrade
2008-09-23 17:38 ` about kernel_physical_mapping_init Joilnen Leite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222205254.9218.30.camel@localhost.localdomain \
--to=zohar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=debora@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=safford@watson.ibm.com \
--cc=serue@linux.vnet.ibm.com \
--cc=srajiv@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome