From: Alexander van Heukelum <heukelum@fastmail.fm>
To: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>
Cc: Alexander van Heukelum <heukelum@fastmail.fm>
Subject: [PATCH 3/7] traps: x86_64: remove trace_hardirqs_fixup from DO_ERROR_INFO macro
Date: Fri, 26 Sep 2008 14:03:04 +0200 [thread overview]
Message-ID: <1222430588-29072-4-git-send-email-heukelum@fastmail.fm> (raw)
In-Reply-To: <1222430588-29072-3-git-send-email-heukelum@fastmail.fm>
All exceptions are taken via interrupt gates. TRACE_IRQS_OFF
is called just before entering the C code, so the irq state
is known to the irq tracer at this point. No need to call
trace_hardirqs_fixup.
Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>
---
arch/x86/kernel/traps_64.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/traps_64.c b/arch/x86/kernel/traps_64.c
index 513caac..04b163e 100644
--- a/arch/x86/kernel/traps_64.c
+++ b/arch/x86/kernel/traps_64.c
@@ -655,7 +655,6 @@ asmlinkage void do_##name(struct pt_regs * regs, long error_code) \
info.si_errno = 0; \
info.si_code = sicode; \
info.si_addr = (void __user *)siaddr; \
- trace_hardirqs_fixup(); \
if (notify_die(DIE_TRAP, str, regs, error_code, trapnr, signr) \
== NOTIFY_STOP) \
return; \
--
1.5.4.3
next prev parent reply other threads:[~2008-09-26 12:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 12:03 [PATCH 0/7] traps: x86: irqtrace cleanup and some traps.c unification Alexander van Heukelum
2008-09-26 12:03 ` [PATCH 1/7] traps: x86_64: add TRACE_IRQS_OFF in error_entry Alexander van Heukelum
2008-09-26 12:03 ` [PATCH 2/7] traps: x86_64: add TRACE_IRQS_OFF in paranoidentry macro Alexander van Heukelum
2008-09-26 12:03 ` Alexander van Heukelum [this message]
2008-09-26 12:03 ` [PATCH 4/7] traps: x86_64: remove trace_hardirqs_fixup from int3 handler Alexander van Heukelum
2008-09-26 12:03 ` [PATCH 5/7] traps: x86_64: remove trace_hardirqs_fixup from debug handler Alexander van Heukelum
2008-09-26 12:03 ` [PATCH 6/7] traps: x86: remove trace_hardirqs_fixup from pagefault handler Alexander van Heukelum
2008-09-26 12:03 ` [PATCH 7/7] traps: i386: make do_trap more like x86_64 Alexander van Heukelum
2008-09-26 12:39 ` [PATCH 1/7] traps: x86_64: add TRACE_IRQS_OFF in error_entry Alexander van Heukelum
2008-09-27 16:30 ` [PATCH 0/7] traps: x86: irqtrace cleanup and some traps.c unification Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222430588-29072-4-git-send-email-heukelum@fastmail.fm \
--to=heukelum@fastmail.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®