From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754871AbYI0CaW (ORCPT ); Fri, 26 Sep 2008 22:30:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751719AbYI0C2U (ORCPT ); Fri, 26 Sep 2008 22:28:20 -0400 Received: from igw2.watson.ibm.com ([129.34.20.6]:54615 "EHLO igw2.watson.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbYI0C2K (ORCPT ); Fri, 26 Sep 2008 22:28:10 -0400 From: "Serge E. Hallyn" To: linux-kernel@vger.kernel.org Cc: linux-security-module@vger.kernel.org Subject: [PATCH 6/6] file capabilities: remove needless (?) bprm_clear_caps calls Date: Fri, 26 Sep 2008 22:27:51 -0400 Message-Id: <1222482472-12847-2-git-send-email-serue@us.ibm.com> X-Mailer: git-send-email 1.6.0.2.GIT In-Reply-To: References: <1222482472-12847-1-git-send-email-serue@us.ibm.com> <7004aef68d149ffb4a11835f37469948496ffc18.1222451103.git.serue@us.ibm.com> <89d3843fc1aaf91ded89d741b2e6d425508e0146.1222451103.git.serue@us.ibm.com> <178a4b5984b7559cb5cdb93b242484386ec3e3ab.1222451103.git.serue@us.ibm.com> <06b2774a667bc535442305193417ff1a479ef1aa.1222451103.git.serue@us.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morgan, if you have a moment, please do take a close look and make sure I'm not doing anything stupid/wrong in the cleanups! However ltp shows no difference with and without the patchset. Following are the kernel sizes after some of the patches. original, pre-patch, with file capabilities compiled out: text data bss dec hex filename 4188468 234432 316472 4739372 48512c vmlinux original, pre-patch, with file capabilities compiled in: 4189356 234432 316472 4740260 4854a4 vmlinux plain with fcaps always-on: 4189392 234456 316472 4740320 4854e0 vmlinux with non-inline cap_safe_nice: 4189112 234456 316472 4740040 4853c8 vmlinux with cleaned-up setcap: 4189120 234456 316472 4740048 4853d0 vmlinux with needless check for target!=current removed from cap_capset: 4189104 234456 316472 4740032 4853c0 vmlinux with needless(?) bprm_clear_caps calls removed: 4189088 234456 316472 4740016 4853b0 vmlinux thanks, -serge