From: Jay Cliburn <jacliburn@bellsouth.net>
To: jeff@garzik.org
Cc: csnook@redhat.com, jie.yang@atheros.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jay Cliburn <jacliburn@bellsouth.net>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: [PATCH 1/4] atl1: fix transmit timeout bug
Date: Sat, 27 Sep 2008 09:17:20 -0500 [thread overview]
Message-ID: <1222525043-4648-2-git-send-email-jacliburn@bellsouth.net> (raw)
In-Reply-To: <1222525043-4648-1-git-send-email-jacliburn@bellsouth.net>
See http://marc.info/?l=linux-netdev&m=121931988219314&w=2
Stop the queue and turn off carrier to prevent transmit timeouts
when the cable is unplugged/replugged.
Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/net/atlx/atl1.c | 4 +++-
drivers/net/atlx/atlx.c | 1 -
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index e23ce77..e00a986 100644
--- a/drivers/net/atlx/atl1.c
+++ b/drivers/net/atlx/atl1.c
@@ -2642,6 +2642,7 @@ static void atl1_down(struct atl1_adapter *adapter)
{
struct net_device *netdev = adapter->netdev;
+ netif_stop_queue(netdev);
del_timer_sync(&adapter->watchdog_timer);
del_timer_sync(&adapter->phy_config_timer);
adapter->phy_timer_pending = false;
@@ -2655,7 +2656,6 @@ static void atl1_down(struct atl1_adapter *adapter)
adapter->link_speed = SPEED_0;
adapter->link_duplex = -1;
netif_carrier_off(netdev);
- netif_stop_queue(netdev);
atl1_clean_tx_ring(adapter);
atl1_clean_rx_ring(adapter);
@@ -2724,6 +2724,8 @@ static int atl1_open(struct net_device *netdev)
struct atl1_adapter *adapter = netdev_priv(netdev);
int err;
+ netif_carrier_off(netdev);
+
/* allocate transmit descriptors */
err = atl1_setup_ring_resources(adapter);
if (err)
diff --git a/drivers/net/atlx/atlx.c b/drivers/net/atlx/atlx.c
index b3e7fcf..3cc9d10 100644
--- a/drivers/net/atlx/atlx.c
+++ b/drivers/net/atlx/atlx.c
@@ -105,7 +105,6 @@ static void atlx_check_for_link(struct atlx_adapter *adapter)
netdev->name);
adapter->link_speed = SPEED_0;
netif_carrier_off(netdev);
- netif_stop_queue(netdev);
}
}
schedule_work(&adapter->link_chg_task);
--
1.5.5.1
next prev parent reply other threads:[~2008-09-27 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 14:17 [PATCH 0/4] atl1: miscellaneous fixes and updates Jay Cliburn
2008-09-27 14:17 ` Jay Cliburn [this message]
2008-09-27 14:17 ` [PATCH 2/4] atl1: remove LLTX Jay Cliburn
2008-09-27 14:17 ` [PATCH 3/4] atl1: remove EXPERIMENTAL label Jay Cliburn
2008-09-27 14:17 ` [PATCH 4/4] atl1: update introductory comments Jay Cliburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222525043-4648-2-git-send-email-jacliburn@bellsouth.net \
--to=jacliburn@bellsouth.net \
--cc=adobriyan@gmail.com \
--cc=csnook@redhat.com \
--cc=jeff@garzik.org \
--cc=jie.yang@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®