From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Chris Friesen <cfriesen@nortel.com>,
Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] sched: trivial fix for incorrect comments
Date: Sat, 27 Sep 2008 20:19:09 +0200 [thread overview]
Message-ID: <1222539550.16700.307.camel@lappy.programming.kicks-ass.net> (raw)
In-Reply-To: <20080927181042.GD1108@elte.hu>
On Sat, 2008-09-27 at 20:10 +0200, Ingo Molnar wrote:
> * Chris Friesen <cfriesen@nortel.com> wrote:
>
> > --- a/kernel/sched.c
> > +++ b/kernel/sched.c
> > @@ -298,9 +298,9 @@ static DEFINE_PER_CPU(struct cfs_rq, init_cfs_rq) ____cacheline_aligned_in_smp;
> > static DEFINE_PER_CPU(struct sched_rt_entity, init_sched_rt_entity);
> > static DEFINE_PER_CPU(struct rt_rq, init_rt_rq) ____cacheline_aligned_in_smp;
> > #endif /* CONFIG_RT_GROUP_SCHED */
> > -#else /* !CONFIG_FAIR_GROUP_SCHED */
> > +#else /* !CONFIG_USER_SCHED */
> > #define root_task_group init_task_group
> > -#endif /* CONFIG_FAIR_GROUP_SCHED */
> > +#endif /* CONFIG_USER_SCHED */
>
> hm, these seem to be fixed already, via:
>
> | commit 9a7e0b180da21885988d47558671cf580279f9d6
> | Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> | Date: Tue Aug 19 12:33:06 2008 +0200
> |
> | sched: rt-bandwidth fixes
>
> is all in tip/master.
>
> (or is perhaps the direction of your patch wrong?)
No I think he got it right, as I vaguely remember fixing it too - now I
know where I left it ;-)
I often leave such trivial comment fixes in whatever patch I'm working
on at that moment.
next prev parent reply other threads:[~2008-09-27 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 15:49 Chris Friesen
2008-09-22 11:00 ` Ingo Molnar
2008-09-23 16:08 ` Chris Friesen
2008-09-27 18:10 ` Ingo Molnar
2008-09-27 18:19 ` Peter Zijlstra [this message]
2008-09-27 18:22 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222539550.16700.307.camel@lappy.programming.kicks-ass.net \
--to=a.p.zijlstra@chello.nl \
--cc=cfriesen@nortel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome