mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: qingtao.cao@windriver.com
Cc: linux-kernel@vger.kernel.org, yanmin.zhang@intel.com
Subject: Re: [PATCH] PCIE: use PCI_EXT_CAP_NEXT to traverse PCIE extended capability list.
Date: Sun, 28 Sep 2008 15:20:16 +0800	[thread overview]
Message-ID: <1222586416.25574.36.camel@ymzhang> (raw)
In-Reply-To: <1222578476-25691-1-git-send-email-qingtao.cao@windriver.com>


On Sun, 2008-09-28 at 13:07 +0800, qingtao.cao@windriver.com wrote:
> PCIE extended capability unit is of 4-byte, so the least 2 bits of the most 
> significant 12 bits should be masked off to zero when accessing the extended
> capability list.
> 
> Signed-off-by: Harry Ciao<qingtao.cao@windriver.com>
Acked-by: Zhang Yanmin <yanmin_zhang@linux.intel.com>

> ---
>  drivers/pci/pcie/aer/aerdrv_core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/pci/pcie/aer/aerdrv_core.c
> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> @@ -52,7 +52,7 @@
>  		if (PCI_EXT_CAP_ID(reg32) == PCI_EXT_CAP_ID_ERR)
>  			break;
>  
> -		pos = reg32 >> 20;
> +		pos = PCI_EXT_CAP_NEXT(reg32);
>  	}
>  
>  	return pos;



      reply	other threads:[~2008-09-28  7:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-28  5:07 qingtao.cao
2008-09-28  7:20 ` Zhang, Yanmin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222586416.25574.36.camel@ymzhang \
    --to=yanmin_zhang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qingtao.cao@windriver.com \
    --cc=yanmin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®