From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753505AbYI3L42 (ORCPT ); Tue, 30 Sep 2008 07:56:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751927AbYI3L4V (ORCPT ); Tue, 30 Sep 2008 07:56:21 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:33258 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbYI3L4U (ORCPT ); Tue, 30 Sep 2008 07:56:20 -0400 Subject: Re: [patch 3/4] cpu alloc: The allocator From: Pekka Enberg To: Christoph Lameter Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rusty@rustcorp.com.au, jeremy@goop.org, ebiederm@xmission.com, travis@sgi.com, herbert@gondor.apana.org.au, xemul@openvz.org In-Reply-To: <48E20F98.4010106@linux-foundation.org> References: <20080929193500.470295078@quilx.com> <20080929193516.278278446@quilx.com> <1222756559.10002.23.camel@penberg-laptop> <48E20F98.4010106@linux-foundation.org> Date: Tue, 30 Sep 2008 14:48:06 +0300 Message-Id: <1222775286.10002.38.camel@penberg-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Mailer: Evolution 2.22.3.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2008-09-30 at 06:38 -0500, Christoph Lameter wrote: > Pekka Enberg wrote: > > >> +/* > >> + * Basic allocation unit. A bit map is created to track the use of each > >> + * UNIT_SIZE element in the cpu area. > >> + */ > >> +#define UNIT_TYPE int > >> +#define UNIT_SIZE sizeof(UNIT_TYPE) > >> + > >> +int units; /* Actual available units */ > > > > What is this thing? Otherwise looks good to me. > > This is the number of units available from the cpu allocator. Its determined > on bootup and the bitmap is sized correspondingly. I think you're confusing it to "nr_units" or, alternatively, I need new glasses.