mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David John <davidjon@xenontk.org>
To: mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, clemens@ladisch.de,
	venkatesh.pallipadi@intel.com, vojtech@suse.cz, bob.picco@hp.com
Subject: [PATCH] HPET: Remove the BKL.
Date: Thu,  9 Oct 2008 16:52:51 +0530	[thread overview]
Message-ID: <1223551371-3764-1-git-send-email-davidjon@xenontk.org> (raw)

Concurrent access is protected by the spin lock hpet_lock. The
BKL is not required.

Signed-off-by: David John <davidjon@xenontk.org>
---
 drivers/char/hpet.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index b3f5dbc..0237eeb 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -194,7 +194,6 @@ static int hpet_open(struct inode *inode, struct file *file)
 	if (file->f_mode & FMODE_WRITE)
 		return -EINVAL;
 
-	lock_kernel();
 	spin_lock_irq(&hpet_lock);
 
 	for (devp = NULL, hpetp = hpets; hpetp && !devp; hpetp = hpetp->hp_next)
@@ -209,7 +208,6 @@ static int hpet_open(struct inode *inode, struct file *file)
 
 	if (!devp) {
 		spin_unlock_irq(&hpet_lock);
-		unlock_kernel();
 		return -EBUSY;
 	}
 
@@ -217,7 +215,6 @@ static int hpet_open(struct inode *inode, struct file *file)
 	devp->hd_irqdata = 0;
 	devp->hd_flags |= HPET_OPEN;
 	spin_unlock_irq(&hpet_lock);
-	unlock_kernel();
 
 	return 0;
 }
@@ -586,7 +583,7 @@ static const struct file_operations hpet_fops = {
 	.llseek = no_llseek,
 	.read = hpet_read,
 	.poll = hpet_poll,
-	.ioctl = hpet_ioctl,
+	.unlocked_ioctl = hpet_ioctl,
 	.open = hpet_open,
 	.release = hpet_release,
 	.fasync = hpet_fasync,

             reply	other threads:[~2008-10-09 11:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-09 11:22 David John [this message]
2008-10-09 12:59 ` Andi Kleen
2008-10-09 14:30   ` David John
  -- strict thread matches above, loose matches on Subject: below --
2008-10-10  8:00 David John
2008-10-09  8:55 David John
2008-10-09 10:31 ` Andi Kleen
2008-10-09 11:08   ` David John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223551371-3764-1-git-send-email-davidjon@xenontk.org \
    --to=davidjon@xenontk.org \
    --cc=bob.picco@hp.com \
    --cc=clemens@ladisch.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®