From: Jiri Slaby <jirislaby@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Jouni Malinen <jmalinen@atheros.com>
Subject: [PATCH 1/1] Ath9k: fix uninitialized value in ath9k_hw_reset
Date: Fri, 10 Oct 2008 19:56:43 +0200 [thread overview]
Message-ID: <1223661403-21803-1-git-send-email-jirislaby@gmail.com> (raw)
status ath9k_hw_reset() parameter should be set in every case, since
it is used in callers to find out an error code.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Luis R. Rodriguez <lrodriguez@atheros.com>
Cc: Jouni Malinen <jmalinen@atheros.com>
---
drivers/net/wireless/ath9k/hw.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath9k/hw.c b/drivers/net/wireless/ath9k/hw.c
index 62e44a0..fb6727b 100644
--- a/drivers/net/wireless/ath9k/hw.c
+++ b/drivers/net/wireless/ath9k/hw.c
@@ -5893,7 +5893,7 @@ bool ath9k_hw_reset(struct ath_hal *ah,
}
if (!ath9k_hw_setpower(ah, ATH9K_PM_AWAKE))
- return false;
+ FAIL(-EIO);
if (curchan)
ath9k_hw_getnf(ah, curchan);
--
1.6.0.2
next reply other threads:[~2008-10-10 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 17:56 Jiri Slaby [this message]
2008-10-10 11:01 ` Luis R. Rodriguez
2008-10-10 18:53 ` David Miller
2008-10-10 19:00 ` Luis R. Rodriguez
2008-10-10 19:00 ` David Miller
2008-10-10 19:07 ` Luis R. Rodriguez
2008-10-10 19:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223661403-21803-1-git-send-email-jirislaby@gmail.com \
--to=jirislaby@gmail.com \
--cc=jmalinen@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®